Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Keyboard: TGR Jane CE #14713

Merged
merged 17 commits into from
Nov 24, 2021
Merged

New Keyboard: TGR Jane CE #14713

merged 17 commits into from
Nov 24, 2021

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented Oct 5, 2021

Description

QMK Support for the TGR Jane CE with is basically just the Jane V2 with an F13 key. So you can actually use the old stuff and omit the F13 key.

In addition redo the directory structure so it makes more sense, we now have a v2 and a v2ce directory.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mechmerlin mechmerlin added keyboard via Adds via keymap and/or updates keyboard for via support labels Oct 5, 2021
@github-actions github-actions bot added the keymap label Oct 5, 2021
keyboards/tgr/jane/v2ce/rules.mk Outdated Show resolved Hide resolved
keyboards/tgr/jane/v2ce/rules.mk Outdated Show resolved Hide resolved
mechmerlin and others added 2 commits October 12, 2021 09:33
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
@mechmerlin
Copy link
Contributor Author

resolved all issues from Drashna

@drashna drashna requested a review from a team November 24, 2021 05:25
@tzarc tzarc changed the base branch from master to develop November 24, 2021 05:28
@tzarc tzarc merged commit 796db50 into qmk:develop Nov 24, 2021
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Dec 2, 2021
* qmk/develop: (80 commits)
  Remove use of __flash due to LTO issues (qmk#15268)
  Revert "handwired/split89 Layout Macro Refactor (qmk#15210)" (qmk#15284)
  New Keyboard: TGR Jane CE (qmk#14713)
  Portal 66 Layout Macro Refactor (qmk#15255)
  Pluckey: Fix QMK Configurator Implementation (qmk#15254)
  [Tests] Increase QMK test coverage take 2 (qmk#15269)
  Ignore exit codes for formatters (qmk#15276)
  [Keyboard] Disable features on SplitKB boards to fit under size (qmk#15262)
  Ignore exit codes for formatters (qmk#15275)
  Ignore deleted files when formatting codebase (qmk#15274)
  qmk format-python - filter for Python files (qmk#15271)
  Revert "[Tests] Increase QMK test coverage (qmk#13789)"
  [Tests] Increase QMK test coverage (qmk#13789)
  [Docs] Squeezing space out of AVR (qmk#15243)
  Add uint to char functions (qmk#15244)
  [Keyboard] Disable console on Keebio foldkb and iris rev3 (qmk#15260)
  layer_combo → sd_combo (qmk#15266)
  [Keymap] Disable console on Sofle default keymap (qmk#15261)
  [Keyboard] Enable LTO on viktus/sp_mini via keymap (qmk#15263)
  Macros in JSON keymaps (qmk#14374)
  ...
@mechmerlin mechmerlin mentioned this pull request Jan 19, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants