Add uint to char functions #15244
Merged
Add uint to char functions #15244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
reviewed
Nov 21, 2021
sigprof
requested changes
Nov 21, 2021
quantum/quantum.c
Outdated
Comment on lines
513
to
515
| buf[3] = (curr_num /= 10) % 10 ? '0' + (curr_num) % 10 : (curr_num / 10) % 10 ? '0' : curr_pad; | ||
| buf[2] = (curr_num /= 10) % 10 ? '0' + (curr_num) % 10 : (curr_num / 10) % 10 ? '0' : curr_pad; | ||
| buf[1] = (curr_num /= 10) % 10 ? '0' + (curr_num) % 10 : (curr_num / 10) % 10 ? '0' : curr_pad; |
There was a problem hiding this comment.
Suggested change
| buf[3] = (curr_num /= 10) % 10 ? '0' + (curr_num) % 10 : (curr_num / 10) % 10 ? '0' : curr_pad; | |
| buf[2] = (curr_num /= 10) % 10 ? '0' + (curr_num) % 10 : (curr_num / 10) % 10 ? '0' : curr_pad; | |
| buf[1] = (curr_num /= 10) % 10 ? '0' + (curr_num) % 10 : (curr_num / 10) % 10 ? '0' : curr_pad; | |
| buf[3] = (curr_num /= 10) ? '0' + curr_num % 10 : curr_pad; | |
| buf[2] = (curr_num /= 10) ? '0' + curr_num % 10 : curr_pad; | |
| buf[1] = (curr_num /= 10) ? '0' + curr_num % 10 : curr_pad; |
The original code would not work properly for a number like 1001 (with at least two consecutive zeros); the whole remaining number needs to be tested when deciding whether the zero needs to be replaced with the padding character.
There was a problem hiding this comment.
yeah, went through a number of iterations, the current code should work properly, but please take a look at it.
8 tasks
tzarc
reviewed
Nov 22, 2021
Co-authored-by: Nick Brassel <nick@tzarc.org>
drashna
force-pushed
the
core/strings
branch
from
d696fd8
to
901560e
Compare
tzarc
requested changes
Nov 22, 2021
Co-authored-by: Nick Brassel <nick@tzarc.org>
tzarc
approved these changes
Nov 22, 2021
zvecr
approved these changes
Nov 22, 2021
cadusk
pushed a commit
to cadusk/qmk_firmware
that referenced
this pull request
Dec 2, 2021
* qmk/develop: (80 commits) Remove use of __flash due to LTO issues (qmk#15268) Revert "handwired/split89 Layout Macro Refactor (qmk#15210)" (qmk#15284) New Keyboard: TGR Jane CE (qmk#14713) Portal 66 Layout Macro Refactor (qmk#15255) Pluckey: Fix QMK Configurator Implementation (qmk#15254) [Tests] Increase QMK test coverage take 2 (qmk#15269) Ignore exit codes for formatters (qmk#15276) [Keyboard] Disable features on SplitKB boards to fit under size (qmk#15262) Ignore exit codes for formatters (qmk#15275) Ignore deleted files when formatting codebase (qmk#15274) qmk format-python - filter for Python files (qmk#15271) Revert "[Tests] Increase QMK test coverage (qmk#13789)" [Tests] Increase QMK test coverage (qmk#13789) [Docs] Squeezing space out of AVR (qmk#15243) Add uint to char functions (qmk#15244) [Keyboard] Disable console on Keebio foldkb and iris rev3 (qmk#15260) layer_combo → sd_combo (qmk#15266) [Keymap] Disable console on Sofle default keymap (qmk#15261) [Keyboard] Enable LTO on viktus/sp_mini via keymap (qmk#15263) Macros in JSON keymaps (qmk#14374) ...
yokada-code
added a commit
to yokada-code/qmk_firmware
that referenced
this pull request
Aug 18, 2023
* Add uint to char functions * appease the all mighty lint * Further appease Lint * Update functions * Add doxygen comment * Update quantum/quantum.c Co-authored-by: Nick Brassel <nick@tzarc.org> * Apply suggestions from code review Co-authored-by: Nick Brassel <nick@tzarc.org> * Add declaration for get_numeric_string * fix formatting and bug Co-authored-by: Nick Brassel <nick@tzarc.org> (Cherry-pick from: 32a87d3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds functions to convert an unsigned int to a char array. Useful for OLEDs and displays, especially on AVR, as things like sprintf take up ~1.5kB of firmware space.
And instead of continually adding the same block of code, add a function into core to do this.
Types of Changes
Checklist