Add Plywrks Lune #17057
Merged
Add Plywrks Lune #17057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keyboard
keymap
via
drashna
requested changes
May 11, 2022
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
drashna
approved these changes
May 12, 2022
fauxpark
requested changes
May 12, 2022
Also added a missing parenthesis in lune.c, and removed the oled_task_user in the default keymap.
noroadsleft
requested changes
Jul 14, 2022
There was a problem hiding this comment.
Also a general comment:
LAYOUT_all appears to be compatible with - if not entirely identical to - LAYOUT_alice_split_bs. You could replace all the instances of the former with the latter, and make the board compatible with the alice_split_bs community layout.
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
fauxpark
requested changes
Aug 12, 2022
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
noroadsleft
approved these changes
Aug 23, 2022
|
Thanks! |
6 tasks
SjB
added a commit
to SjB/qmk_firmware
that referenced
this pull request
Sep 16, 2022
* upstream/master: (41 commits) Add missing DD mapping for RGB_MATRIX_DRIVER (qmk#18160) Refactor pianoforte for configurator (qmk#18159) Fix use of encoder map in mechlovin/zed65/retro66 (qmk#18158) Fix use of encoder map in mechlovin/foundation (qmk#18157) Update invalid pip install flag (qmk#18146) Fix use of encoder map in mechwild/clunker (qmk#18156) [Keyboard] Add Plywrks Lune (qmk#17057) [Keyboard] Add Clunker (qmk#18141) Use correct board files for cantor (qmk#18144) [Keyboard] Enable VIA - ALF X1.1 (qmk#18140) [Keyboard] add rgb animation handwired/swiftrax/glacier (qmk#18121) Update Tap Dance Example 4 (qmk#18138) Remove USB IDs and strings from `fungo/rev1` (qmk#18133) Move keyboard USB IDs and strings to data driven, pass 3 (qmk#18111) Add pcewing Speedo v3 keymap (qmk#18118) [Keymap] Add new keymap to nasu (qmk#18024) [Keyboard] Add ai macropad (qmk#17722) added keymap for kprepublic/jj40:brdlf (qmk#17961) [Keyboard] Add yandrstudio/nz67v2 keyboard. (qmk#17591) Format code according to conventions (qmk#18119) ...
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
* Add Plywrks Lune * Add OLED functionality * Update keyboards/plywrks/lune/keymaps/default/keymap.c * Update keyboards/plywrks/lune/keymaps/via/keymap.c * Update keyboards/plywrks/lune/keymaps/via/keymap.c * Update keyboards/plywrks/lune/lune.c * Add the missing 2 layers in the keymap Also added a missing parenthesis in lune.c, and removed the oled_task_user in the default keymap. * Update keyboards/plywrks/lune/info.json * Update keyboards/plywrks/lune/info.json * Update keyboards/plywrks/lune/info.json * Update keyboards/plywrks/lune/config.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the Plywrks Lune.
Types of Changes
Checklist