Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor pianoforte for configurator #18159

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Refactor pianoforte for configurator #18159

merged 2 commits into from
Aug 24, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Aug 24, 2022 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Aug 24, 2022
@zvecr zvecr added the bug label Aug 24, 2022
@zvecr zvecr marked this pull request as draft August 24, 2022 19:45
@zvecr zvecr marked this pull request as ready for review August 24, 2022 19:47
@zvecr zvecr requested a review from a team August 24, 2022 19:47
@drashna drashna merged commit 4a67123 into qmk:master Aug 24, 2022
SjB added a commit to SjB/qmk_firmware that referenced this pull request Sep 16, 2022
@SjB
Merge remote-tracking branch 'upstream/master' into sjb/all-keyboard
f3c6ce9 
* upstream/master: (41 commits)
  Add missing DD mapping for RGB_MATRIX_DRIVER (qmk#18160)
  Refactor pianoforte for configurator (qmk#18159)
  Fix use of encoder map in mechlovin/zed65/retro66 (qmk#18158)
  Fix use of encoder map in mechlovin/foundation (qmk#18157)
  Update invalid pip install flag (qmk#18146)
  Fix use of encoder map in mechwild/clunker (qmk#18156)
  [Keyboard] Add Plywrks Lune (qmk#17057)
  [Keyboard] Add Clunker (qmk#18141)
  Use correct board files for cantor (qmk#18144)
  [Keyboard] Enable VIA - ALF X1.1 (qmk#18140)
  [Keyboard] add rgb animation handwired/swiftrax/glacier (qmk#18121)
  Update Tap Dance Example 4 (qmk#18138)
  Remove USB IDs and strings from `fungo/rev1` (qmk#18133)
  Move keyboard USB IDs and strings to data driven, pass 3 (qmk#18111)
  Add pcewing Speedo v3 keymap (qmk#18118)
  [Keymap] Add new keymap to nasu (qmk#18024)
  [Keyboard] Add ai macropad (qmk#17722)
  added keymap for kprepublic/jj40:brdlf (qmk#17961)
  [Keyboard] Add yandrstudio/nz67v2 keyboard. (qmk#17591)
  Format code according to conventions (qmk#18119)
  ...
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@zvecr @nolanseaton
Refactor pianoforte for configurator (qmk#18159)
b81c210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
bug keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @drashna @fauxpark