Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update creek70 add RGB matrix function #19858

Closed
wants to merge 6 commits into from
Closed

update creek70 add RGB matrix function #19858

wants to merge 6 commits into from

Conversation

spbgzh
Copy link
Contributor

@spbgzh spbgzh commented Feb 16, 2023

Description

RGB light in the right side(3) change to red when capslock is 1, and otherwise it will be a single color.
RGB light in the left side(4), will have RGB animation as usual.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

#19789
*

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 16, 2023
@spbgzh spbgzh mentioned this pull request Mar 3, 2023
Closed
6 tasks
drashna
drashna requested changes Mar 7, 2023
View reviewed changes
keyboards/wuque/creek70/creek70.c Outdated Show resolved Hide resolved
keyboards/wuque/creek70/creek70.c Outdated Show resolved Hide resolved
keyboards/wuque/creek70/creek70.c Outdated Show resolved Hide resolved
keyboards/wuque/creek70/creek70.c Outdated
{NO_LED, NO_LED, NO_LED, NO_LED, NO_LED, NO_LED, NO_LED, NO_LED, NO_LED, NO_LED, NO_LED, NO_LED, NO_LED, NO_LED, NO_LED, NO_LED, NO_LED, NO_LED},
{NO_LED, NO_LED, NO_LED, NO_LED, NO_LED, NO_LED, NO_LED, NO_LED, NO_LED, NO_LED, NO_LED, NO_LED, NO_LED, NO_LED, NO_LED, NO_LED, NO_LED, NO_LED},
},
{},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be filled out with x and y coordinates, so that animations can be properly parsed.

spbgzh and others added 4 commits March 13, 2023 15:40
@spbgzh @drashna
Update keyboards/wuque/creek70/creek70.c
7b7973d 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@spbgzh @drashna
Update keyboards/wuque/creek70/creek70.c
caae50f 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@spbgzh @drashna
Update keyboards/wuque/creek70/creek70.c
5cb991f 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@spbgzh
update
71614a5
@spbgzh spbgzh closed this Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna requested changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spbgzh @drashna