add creek70 #1697
Closed
add creek70 #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xelus22
requested changes
Feb 15, 2023
Comment on lines
+23
to
+30
| "options": [ | ||
| "All Off", | ||
| "Solid Color", | ||
| "Breathing", | ||
| "Rainbow Moving Chevron", | ||
| "Rainbow Beacon", | ||
| "Rainbow Pinwheels" | ||
| ] |
There was a problem hiding this comment.
From your keyboard config.h there are only Breathing, Rainbow Mood and Static gradient. Is this correct?
There was a problem hiding this comment.
yes, different kinds of Rainbow effection is for rgb matrix.
There was a problem hiding this comment.
However you do not have RGB matrix at all? You only have RGB Light.
You only have
#define RGBLIGHT_EFFECT_BREATHING
#define RGBLIGHT_EFFECT_RAINBOW_MOOD
#define RGBLIGHT_EFFECT_STATIC_GRADIENT
There was a problem hiding this comment.
I added long time ago, seill no one check. ( qmk/qmk_firmware#19858
Co-authored-by: Xelus22 <17491233+Xelus22@users.noreply.github.com>
|
I will close this PR for now please ping us when QMK is merged and I will reopen it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
QMK Pull Request
qmk/qmk_firmware#19789
Checklist
0xFEED