-
-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding my keymap #20345
Adding my keymap #20345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you have changes to the submodules here. These need to be reverted before the PR can be approved.
Rebasing sometimes will fix this. Otherwise, you'd want to do something like this to fix them:
git checkout master
git submodule foreach 'git log -n1 --oneline'
# remember the first abcdef1234 on the submodules that have an issue
git checkout @@your-branch@@
# for each of the problematic repo's:
cd lib/@@name@@
git checkout abcdef1234
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated as per requests
Note: #20345 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made requested changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated as per requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made requested changes
Two reviewers have requested you rename your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readme.md
should actually be lowercase now. I renamed it locally when I was initially requested to change it to lowercase, but it never updated here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing older changes
SEND_STRING(":disguised_face: :thumbsup:"); | ||
wait_ms(100); | ||
tap_code(KC_ENTER); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SEND_STRING(":disguised_face: :thumbsup:"); | |
wait_ms(100); | |
tap_code(KC_ENTER); | |
SEND_STRING(":disguised_face: :thumbsup:" SS_DELAY(100) SS_TAP(X_ENTER)); |
* upstream/master: (46 commits) [Keyboard] Add 1upkeyboards pi50 (qmk#20242) `sofle/via` encoder map & doc handedness update (qmk#20630) [Keyboard] add phantagom/baragon marcopad (qmk#20543) [Keyboard] add phantagom/varan rgb numpad (qmk#20587) [Keymap] Small changes to fix failing karn keyboard build (qmk#20618) Repair Spleeb i2c config and chrishoage keymap (qmk#20644) Adding my keymap (qmk#20345) Add additional options for Drag Scroll config (qmk#20523) Added Velvet Hotswap and Solder PCBs (qmk#20510) [Keyboard] Add the Aster Ergo PCB (qmk#20513) vertex/angle65 - Implement RGBlight (qmk#20514) [Keymap update] Keymap & docs update (qmk#20298) Fix MATRIX_HAS_GHOST when MATRIX_COL > 16 (qmk#20093) ez_maker/directpins/promicro: Fix bootloader mismatch (qmk#20627) Fix up positioning of keys for Keychron Q10/V10 and Q6/V6 (qmk#20582) [Keymap] Add johnstegeman iris colemak keymap (qmk#20575) [Keyboard] Add Manibus VIA support (qmk#20497) Add KBDCraft Adam64 Lego board (qmk#20503) Update code example to match description (qmk#20528) NK Plus (qmk#20392) ...
Description
Adding my Iris keymap, focused on editing in VIM/Excel, gaming, and keyboard-focused media consumption.
Types of Changes
Issues Fixed or Closed by This PR
Checklist