Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional options for Drag Scroll config #20523

Merged
merged 2 commits into from
Apr 30, 2023
Merged

Conversation

doesntfazer
Copy link
Contributor

@doesntfazer doesntfazer commented Apr 21, 2023

I thought it was important to document different ways you can change drag scrolling to make it an even better feature.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Added some additional information to Drag scrolling

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

I thought it was important to document different ways you can change drag scrolling to make it an even better feature.
Fixed a couple of issue with the example code that I provided. 2 issues, if you left the mouse layer while still holding drag scroll it would stay held down. Fixed that issue. In addition to that, if you move the pointing device too slowly, it wouldn't scroll. Caused by the way that the scroll values were being stored.
@drashna drashna requested a review from a team April 22, 2023 07:55
@tzarc tzarc merged commit 40380c2 into qmk:master Apr 30, 2023
struckmb pushed a commit to struckmb/qmk_firmware that referenced this pull request May 1, 2023
rodrigob pushed a commit to rodrigob/qmk_firmware that referenced this pull request May 2, 2023
barrettclark added a commit to barrettclark/qmk_firmware that referenced this pull request May 4, 2023
* upstream/master: (46 commits)
  [Keyboard] Add 1upkeyboards pi50 (qmk#20242)
  `sofle/via` encoder map & doc handedness update (qmk#20630)
  [Keyboard] add phantagom/baragon marcopad (qmk#20543)
  [Keyboard] add phantagom/varan rgb numpad (qmk#20587)
  [Keymap] Small changes to fix failing karn keyboard build (qmk#20618)
  Repair Spleeb i2c config and chrishoage keymap (qmk#20644)
  Adding my keymap (qmk#20345)
  Add additional options for Drag Scroll config (qmk#20523)
  Added Velvet Hotswap and Solder PCBs (qmk#20510)
  [Keyboard] Add the Aster Ergo PCB (qmk#20513)
  vertex/angle65 - Implement RGBlight (qmk#20514)
  [Keymap update] Keymap & docs update (qmk#20298)
  Fix MATRIX_HAS_GHOST when MATRIX_COL > 16 (qmk#20093)
  ez_maker/directpins/promicro: Fix bootloader mismatch (qmk#20627)
  Fix up positioning of keys for Keychron Q10/V10 and Q6/V6 (qmk#20582)
  [Keymap] Add johnstegeman iris colemak keymap (qmk#20575)
  [Keyboard] Add Manibus VIA support (qmk#20497)
  Add KBDCraft Adam64 Lego board (qmk#20503)
  Update code example to match description (qmk#20528)
  NK Plus (qmk#20392)
  ...
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants