Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PWM advanced check for WS2812 driver #22830

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Remove PWM advanced check for WS2812 driver #22830

merged 1 commit into from
Jan 5, 2024

Conversation

drashna
Copy link
Member

@drashna drashna commented Jan 5, 2024

Description

Per comment by sigprof, STM32_PWM_USE_ADVANCED was dropped, and support for complementary channels expanded. Updating the WS2812 PWM driver to reflect those changes.

Types of Changes

  • Core
  • Bugfix
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested review from sigprof and a team January 5, 2024 11:19
@github-actions github-actions bot added the core label Jan 5, 2024
@zvecr zvecr merged commit 7ed3138 into qmk:develop Jan 5, 2024
3 of 4 checks passed
@drashna drashna deleted the ws2812_pwm branch January 5, 2024 21:15
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
@drashna @itsjonny96
Remove PWM advanced check for WS2812 driver (qmk#22830)
783b7ff
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
@drashna @mechlovin
Remove PWM advanced check for WS2812 driver (qmk#22830)
ff6f69d
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
@drashna @mechlovin
Remove PWM advanced check for WS2812 driver (qmk#22830)
5aa5614
@josh-l-wang josh-l-wang mentioned this pull request Feb 15, 2024
Closed
@sigprof sigprof mentioned this pull request Mar 17, 2024
Closed
14 tasks
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@drashna @nuess0r
Remove PWM advanced check for WS2812 driver (qmk#22830)
1f94e98
@zvecr zvecr mentioned this pull request Sep 24, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpekenin elpekenin elpekenin approved these changes

@fauxpark fauxpark fauxpark approved these changes

@sigprof sigprof Awaiting requested review from sigprof

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drashna @fauxpark @elpekenin @zvecr