Replace usage of @AlternativePriority with @Alternative + @Priority #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `@AlternativePriority` annotation has been deprecated since Quarkus 2.6 and is being removed in Quarkus 3.0. The replacement is a combination of `@Alternative` and `@Priority`. There are in fact _two_ `@Priority` annotations to choose from: - `javax.annotation.Priority` - `io.quarkus.arc.Priority` The `javax.annotation.Priority` annotation cannot be put on methods, and its `jakarta.annotation.Priority` counterpart can only be put on methods since Common Annotations 2.1 (Jakarta EE 10). Therefore, this commit uses `io.quarkus.arc.Priority`, even though it is getting deprecated in Quarkus 3.0, to allow maintaining Quarkus 2.x and 3.x compatibility through mechanical transformation.
brunobat
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@AlternativePriorityannotation has been deprecated since Quarkus 2.6 and is being removed in Quarkus 3.0 (see quarkusio/quarkus#30963 and quarkusio/quarkus#31033). The replacement is a combination of@Alternativeand@Priority.There are in fact two
@Priorityannotations to choose from:javax.annotation.Priorityio.quarkus.arc.PriorityThe
javax.annotation.Priorityannotation cannot be put on methods, and itsjakarta.annotation.Prioritycounterpart can only be put on methods since Common Annotations 2.1 (Jakarta EE 10).Therefore, this commit uses
io.quarkus.arc.Priority, even though it is getting deprecated in Quarkus 3.0, to allow maintaining Quarkus 2.x and 3.x compatibility in this project through mechanical transformation. If that is not necessary and this project moves to Quarkus 3.x unconditionally, usingjakarta.annotation.Prioritywould be a better choice.