Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArC: remove deprecated @AlternativePriority #30963

Closed
Ladicek opened this issue Feb 7, 2023 · 2 comments · Fixed by #31033
Closed

ArC: remove deprecated @AlternativePriority #30963

Ladicek opened this issue Feb 7, 2023 · 2 comments · Fixed by #31033
Assignees
@Ladicek
Labels
area/arc Issue related to ARC (dependency injection) area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Milestone
3.0.0.Alpha5

Comments

@Ladicek
Copy link
Contributor

Ladicek commented Feb 7, 2023

Description

The @AlternativePriority annotation has been deprecated since Quarkus 2.6 and it seem 3.0 is a good time to drop it. However, it is used in several core Quarkus extensions and at least one Quarkiverse extension, so I'm filing a separate issue for that and will submit a standalone PR. The migration path is simple: replace this annotation with the combination of:

  • either @jakarta.enterprise.inject.Alternative + @io.quarkus.arc.Priority (this is getting deprecated),
  • or @jakarta.enterprise.inject.Alternative + @jakarta.annotation.Priority.

Implementation ideas

  1. Replace with @jakarta.enterprise.inject.Alternative + @jakarta.annotation.Priority in the Quarkus core repo.
  2. Submit a PR to the Quarkiverse extension affected.
  3. Remember to add a note to the 3.0 migration guide.
@Ladicek Ladicek added area/arc Issue related to ARC (dependency injection) area/housekeeping Issue type for generalized tasks not related to bugs or enhancements labels Feb 7, 2023
@Ladicek Ladicek self-assigned this Feb 7, 2023
@Ladicek Ladicek mentioned this issue Feb 7, 2023
Merged
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 7, 2023

/cc @manovotn (arc), @mkouba (arc)

@mkouba mkouba added this to the 3.0 - main milestone Feb 8, 2023
This was referenced Feb 9, 2023
Merged
Merged
@Ladicek
Copy link
Contributor Author

Ladicek commented Feb 9, 2023

All 3 items done:

  1. ArC: remove deprecated @AlternativePriority #31033
  2. Replace usage of @AlternativePriority with @Alternative + @Priority quarkiverse/quarkus-micrometer-registry#243
  3. https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.0/3dbde8b0c75232b5e7bdb9326abc10f3108cc444

@gsmet gsmet removed this from the 3.0.0.Alpha4 milestone Feb 9, 2023
gastaldi added a commit that referenced this issue Feb 10, 2023
@gastaldi
Merge pull request #31033 from Ladicek/remove-alternativepriority
3bb418d 
Resolves #30963
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ladicek Ladicek

Labels
area/arc Issue related to ARC (dependency injection) area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Projects
None yet
Milestone
3.0.0.Alpha5
Development

Successfully merging a pull request may close this issue.

ArC: remove deprecated @AlternativePriority Ladicek/quarkus
3 participants
@Ladicek @mkouba @gsmet