Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tests with Quarkus OpenShift extension as upstream issue is fixed #704

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Enable tests with Quarkus OpenShift extension as upstream issue is fixed #704

merged 1 commit into from
Mar 13, 2023

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Mar 11, 2023 •
edited
Loading

Summary

Enable tests using Quarkus OpenShift extension as quarkusio/quarkus#31228 is resolved.
New issue opened quarkusio/quarkus#31787 for Knative scenarios.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik force-pushed the feature/enable-tests-using-oc-extension branch from a318f1e to ad53fdc Compare March 11, 2023 22:48
@michalvavrik
Enable tests with Quarkus OpenShift extension as upstream issue is fixed
530e34c 
Enable tests using Quarkus OpenShift extension as quarkusio/quarkus#31228 is resolved.
@michalvavrik michalvavrik force-pushed the feature/enable-tests-using-oc-extension branch from ad53fdc to 530e34c Compare March 11, 2023 22:51
@michalvavrik michalvavrik changed the title WIP: Enable tests with Quarkus OpenShift extension as upstream issue is fixed Enable tests with Quarkus OpenShift extension as upstream issue is fixed Mar 11, 2023
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik
Copy link
Member Author

michalvavrik commented Mar 12, 2023 •
edited
Loading

There is one OC native failure over OOM that (naturally) can't be reproduced locally - not related.

But we should do something about it, because it is not the first time I've seen this here.

@michalvavrik michalvavrik requested a review from mjurc March 12, 2023 09:08
@mjurc
Copy link
Member

mjurc commented Mar 13, 2023

run tests

@mjurc mjurc merged commit acf885a into quarkus-qe:main Mar 13, 2023
@mjurc
Copy link
Member

mjurc commented Mar 13, 2023

LGTM, thanks

@michalvavrik michalvavrik deleted the feature/enable-tests-using-oc-extension branch March 13, 2023 16:07
@michalvavrik michalvavrik mentioned this pull request Mar 13, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjurc mjurc Awaiting requested review from mjurc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalvavrik @mjurc