-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Knative deployer client check always fails over missing KnativeExtensionAdapter #31787
Comments
This is a regression issue that starts happening in Alpha4 (it worked fine in Alpha3). I'm not sure if this is related to the new Kubernetes Client version: #30480 What is odd is that the knative-client dependency seems to be there. |
I think it might be related to the check removal. The best way would be to actually check if the cluster supports the specific resources that we're going to use. Is there a test that verifies this? if so I can provide a PR to explore a possible fix. |
There is no test that covers this scenario and we should add it (I will add one after I finish off some stuff). However, in the mean time, you can use the reproducer provided in the description:
I've updated the reproducer to directly use the Kubernetes extension. I think it does not matter if you're connected to a K8s environment, because it fails before deploying the app. |
Describe the bug
Using
quarkus.kubernetes.deployment-target=knative
always fails as matching adapter is missing. It's a regression as this was possible with 2.16.4.Expected behavior
Works.
Actual behavior
Build fails with exception:
How to Reproduce?
Steps to reproduce:
oc new-project mvavrik-debug
quarkus create app knative-reproducer -x openshift,resteasy-reactive --stream=3.0
cd knative-reproducer/
mvn clean verify -Dquarkus.platform.version=999-SNAPSHOT -Dquarkus.platform.group-id=io.quarkus -Dquarkus.kubernetes.deployment-target=knative -Dquarkus.kubernetes.deploy=true -Dquarkus.kubernetes-client.trust-certs=true -Dquarkus.container-image.registry=image-registry.openshift-image-registry.svc:5000
Optional steps:
5. I added Knative Client and it made no difference
Output of
uname -a
orver
Linux
Output of
java -version
No response
GraalVM version (if different from Java)
OpenJDK 64-Bit Server VM Temurin-17.0.5+8
Quarkus version or git rev
999-SNAPSHOT (commit 7909903) and 3.0.0.Alpha5
Build tool (ie. output of
mvnw --version
orgradlew --version
)Apache Maven 3.8.6
Additional information
No response
The text was updated successfully, but these errors were encountered: