Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ping-pong resource tests with Quarkus OpenShift extension #718

Merged
merged 1 commit into from
Mar 26, 2023
Merged

Enable ping-pong resource tests with Quarkus OpenShift extension #718

merged 1 commit into from
Mar 26, 2023

Conversation

gtroitsk
Copy link
Member

Summary

Enable tests using Quarkus OpenShift extension as quarkusio/quarkus#31787 is resolved.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@gtroitsk
Copy link
Member Author

run tests

michalvavrik
michalvavrik approved these changes Mar 26, 2023
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-run OC tests (there was outage on Friday) and CI is green. LGTM, thx

@michalvavrik michalvavrik merged commit 9c7abe5 into quarkus-qe:main Mar 26, 2023
@gtroitsk gtroitsk deleted the openshift-extension-pingpong branch March 27, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtroitsk @michalvavrik