Upgrade to Liquibase 4.24.0

[appiepollo14]

Fixes #36446

[appiepollo14]

Does Liquibase 4.23 need to be excluded somewhere?
Does this need to be backported? If so, how?

[geoand]

If CI is green, we can merge and backport to 3.5.

For 3.4, I'll leave it up to @gsmet to decide

[appiepollo14]

Can you explain how to do the backporting? Create a p.r. to tag 3.5?

[geoand]

You don't need to do anything, we'll take care of it.

[gsmet]

Thanks but could you please also update liquibase-mongodb?

[gsmet]

Also, would this issue be reproducible in a test case? Because that's unfortunate we broke things and we didn't catch it.

[appiepollo14]

@gsmet will look into a testcase

[famod]

I think we should now be able to remove that LabelExpression workaround I had to add to the previous Liquibase update PR.
IMO, that doesn't block this PR from being merged though.

PS: I'm on PTO for the rest of this month. So if anyone else wants to remove the workaround please feel free to do so.

[appiepollo14]

Build seems to be failing on other parts of the project...

[gsmet]

I squashed the commits.

Let's see what CI has to say. It might not be fully green but it looks good enough so it should be mergeable.

[quarkus-bot]

Failing Jobs - Building 219e6d8

Status	Name	Step	Failures	Logs	Raw logs	Build scan
✔️	Maven Tests - JDK 11
✖	Maven Tests - JDK 11 Windows	Build	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Maven Tests - JDK 11 Windows #

- Failing: integration-tests/maven 

📦 integration-tests/maven

✖ io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.JarRunnerIT.testPlatformPropertiesOverridenInApplicationProperties line 135 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.JarRunnerIT that uses io.quarkus.maven.it.verifier.MavenProcessInvocationResult was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.JarRunnerIT.testPlatformPropertiesOverridenInApplicationProperties line 135 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.JarRunnerIT that uses io.quarkus.maven.it.verifier.MavenProcessInvocationResult was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

[appiepollo14]

Dependabot has opened the same PR on the meantime. I haven’t found the time looking for an IT but will focus on that!

[gsmet]

@appiepollo14 I merged this but still interested if you can come up with an IT, just open a new PR. Thanks!