-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take ReaderInterceptor into account when reading SSE events #36490
Conversation
This comment has been minimized.
This comment has been minimized.
...lient/runtime/src/main/java/org/jboss/resteasy/reactive/client/impl/InboundSseEventImpl.java
Outdated
Show resolved
Hide resolved
e9eac73
to
9adb6b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it better, thanks :).
I will let @gastaldi review it though as you asked for his review.
Thanks for checking! |
This comment has been minimized.
This comment has been minimized.
9adb6b6
to
6a84fe9
Compare
Failing Jobs - Building 6a84fe9
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 20 #- Failing: integration-tests/virtual-threads/amqp-virtual-threads integration-tests/virtual-threads/jms-virtual-threads integration-tests/virtual-threads/kafka-virtual-threads and 1 more
📦 integration-tests/virtual-threads/amqp-virtual-threads✖
✖
📦 integration-tests/virtual-threads/jms-virtual-threads✖
✖
📦 integration-tests/virtual-threads/kafka-virtual-threads✖
✖
📦 integration-tests/virtual-threads/rest-client-reactive-virtual-threads✖
|
@cescoffier @ozangunalp the AMQP virtual threads test seems to be flaky |
The mailer one too. |
This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [flow-bin](https://github.com/flowtype/flow-bin) ([changelog](https://github.com/facebook/flow/blob/master/Changelog.md)) | devDependencies | minor | [`^0.219.0` -> `^0.220.0`](https://renovatebot.com/diffs/npm/flow-bin/0.219.0/0.220.0) | | [org.jsoup:jsoup](https://jsoup.org/) ([source](https://github.com/jhy/jsoup)) | compile | patch | `1.16.1` -> `1.16.2` | | [io.quarkus:quarkus-maven-plugin](https://github.com/quarkusio/quarkus) | build | minor | `3.4.3` -> `3.5.0` | | [io.quarkus:quarkus-universe-bom](https://github.com/quarkusio/quarkus-platform) | import | minor | `3.4.3` -> `3.5.0` | --- ### Release Notes <details> <summary>flowtype/flow-bin</summary> ### [`v0.220.0`](flow/flow-bin@f7f3f3f...030bfc6) [Compare Source](flow/flow-bin@f7f3f3f...030bfc6) ### [`v0.219.5`](flow/flow-bin@f16a6c7...f7f3f3f) [Compare Source](flow/flow-bin@f16a6c7...f7f3f3f) ### [`v0.219.4`](flow/flow-bin@9f67075...f16a6c7) [Compare Source](flow/flow-bin@9f67075...f16a6c7) ### [`v0.219.3`](flow/flow-bin@80dcea5...9f67075) [Compare Source](flow/flow-bin@80dcea5...9f67075) ### [`v0.219.2`](flow/flow-bin@c184c5d...80dcea5) [Compare Source](flow/flow-bin@c184c5d...80dcea5) </details> <details> <summary>quarkusio/quarkus</summary> ### [`v3.5.0`](https://github.com/quarkusio/quarkus/releases/tag/3.5.0) [Compare Source](quarkusio/quarkus@3.4.3...3.5.0) ##### Complete changelog - [#​36527](quarkusio/quarkus#36527) - Start MongoDB 4.4 instead of 4.0 - [#​36523](quarkusio/quarkus#36523) - Minor OIDC Auth0 updates - [#​36518](quarkusio/quarkus#36518) - Allow for setting logging scope programmatically - [#​36517](quarkusio/quarkus#36517) - Use Mandrel 23.1 in windows CI - [#​36501](quarkusio/quarkus#36501) - Let custom OIDC token propagation filters customize the exchange status - [#​36495](quarkusio/quarkus#36495) - Support external OTel exporters in CDI - [#​36490](quarkusio/quarkus#36490) - Take ReaderInterceptor into account when reading SSE events - [#​36487](quarkusio/quarkus#36487) - Upgrade to Liquibase 4.24.0 - [#​36485](quarkusio/quarkus#36485) - Fix typo in gradle-tooling.adoc - [#​36474](quarkusio/quarkus#36474) - Fix some issues in getting-started-dev-services - [#​36465](quarkusio/quarkus#36465) - Be more consistent in guides when creating projects/adding extensions - [#​36464](quarkusio/quarkus#36464) - HTTP reference guide - HTTP/2 section update, drop JDK 8 note - [#​36459](quarkusio/quarkus#36459) - Let custom OIDC token propagation filters provide client name - [#​36457](quarkusio/quarkus#36457) - Update builder images to jdk-21 - [#​36453](quarkusio/quarkus#36453) - Upgrade Oracle JDBC driver to 23.3.0.23.09 - [#​36452](quarkusio/quarkus#36452) - Fix doc extension-add.adoc - [#​36451](quarkusio/quarkus#36451) - Adjust extension name for consistency with rest of Quarkus - [#​36446](quarkusio/quarkus#36446) - Regression: Liquibase fails to migrate on Quarkus start, crashing the application - [#​36445](quarkusio/quarkus#36445) - Updates to Infinispan 14.0.19.Final - [#​36442](quarkusio/quarkus#36442) - Use default content type when X-SSE header not set - [#​36436](quarkusio/quarkus#36436) - Upgrade to Hibernate ORM 6.2.13.Final - [#​36432](quarkusio/quarkus#36432) - Hibernate Reactive Panache: improve error message - [#​36420](quarkusio/quarkus#36420) - Allow parallel execution of blocking health checks - [#​36419](quarkusio/quarkus#36419) - Blocking Health Checks should be executed in parallel, not sequentially/ordered - [#​36417](quarkusio/quarkus#36417) - Reduce timeout of the doc build to 60 minutes - [#​36413](quarkusio/quarkus#36413) - Simplify virtual threads guide by pushing users to 21 - [#​36412](quarkusio/quarkus#36412) - Drop Optaplanner from the documentation - [#​36411](quarkusio/quarkus#36411) - Drop panache topic from Hibernate Reactive guide - [#​36410](quarkusio/quarkus#36410) - Add compatibility topic to Spring guides - [#​36407](quarkusio/quarkus#36407) - Register RuntimeOverrideConfigSource in STATIC_INIT - [#​36406](quarkusio/quarkus#36406) - AssembleDownstreamDocumentation - print guide name - [#​36400](quarkusio/quarkus#36400) - Add topics and extensions metadata to guides - [#​36367](quarkusio/quarkus#36367) - Bump org.wiremock:wiremock-standalone from 3.1.0 to 3.2.0 - [#​36365](quarkusio/quarkus#36365) - Bump de.flapdoodle.embed:de.flapdoodle.embed.mongo from 4.7.0 to 4.9.2 - [#​36360](quarkusio/quarkus#36360) - Drop the old Dev UI guide - [#​36337](quarkusio/quarkus#36337) - Upgrade maven to version 3.9.5 - [#​36236](quarkusio/quarkus#36236) - No Panache session in REST endpoints defined by an interface - [#​35931](quarkusio/quarkus#35931) - Add OIDC Auth0 extended tutorial - [#​33548](quarkusio/quarkus#33548) - Pick random debug port when the configured one is taken - [#​33363](quarkusio/quarkus#33363) - allow quarkus dev to pick random debug port </details> <details> <summary>quarkusio/quarkus-platform</summary> ### [`v3.5.0`](quarkusio/quarkus-platform@3.4.3...3.5.0) [Compare Source](quarkusio/quarkus-platform@3.4.3...3.5.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This MR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMCJ9-->
No description provided.