-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.6] Upgrade to Hibernate ORM 6.2.18.Final #38099
Conversation
@@ -97,7 +97,7 @@ | |||
<classmate.version>1.5.1</classmate.version> | |||
<!-- When updating, align bytebuddy.version to Hibernate needs as well (just below), | |||
as well as hibernate-orm.version-for-documentation in docs/pom.xml --> | |||
<hibernate-orm.version>6.2.13.Final</hibernate-orm.version> | |||
<hibernate-orm.version>6.2.18.Final</hibernate-orm.version> | |||
<bytebuddy.version>1.14.7</bytebuddy.version> <!-- Version controlled by Hibernate ORM's needs --> | |||
<hibernate-commons-annotations.version>6.0.6.Final</hibernate-commons-annotations.version> <!-- version controlled by Hibernate ORM --> | |||
<hibernate-reactive.version>2.0.6.Final</hibernate-reactive.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe upgrade to HR 2.0.7 while you're at it? It was supposedly the version to use with ORM 6.2.13.Final...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the other dependencies but not this one. Done and thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't hibernate/hibernate-reactive@163eee7 problematic as 3.6 branch is using Vert.x 4.4 - https://github.com/quarkusio/quarkus/blob/3.6/bom/application/pom.xml#L121 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DavideD Any idea where this upgrade comes from? Seems strange to upgrade to a new vertx version in a micro of Hibernate Reactive...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, which upgrade? Hibernate Reactive uses Vert.x 4.4 since 2.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DavideD The one @rsvoboda linked just above: hibernate/hibernate-reactive@163eee7
It's on the 2.0 branch, oddly, and also included in 2.0.7.Final.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a mistake on my part.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
fe052d3
to
0e6a4b3
Compare
I removed the Hibernate Reactive upgrade for now. |
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Let's try to get 6.2.18.Final for the Quarkus 3.6.5 I will release tomorrow.