Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.6] Upgrade to Hibernate ORM 6.2.18.Final #38099

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jan 9, 2024

Let's try to get 6.2.18.Final for the Quarkus 3.6.5 I will release tomorrow.

@gsmet gsmet requested a review from yrodiere January 9, 2024 13:16
@@ -97,7 +97,7 @@
<classmate.version>1.5.1</classmate.version>
<!-- When updating, align bytebuddy.version to Hibernate needs as well (just below),
as well as hibernate-orm.version-for-documentation in docs/pom.xml -->
<hibernate-orm.version>6.2.13.Final</hibernate-orm.version>
<hibernate-orm.version>6.2.18.Final</hibernate-orm.version>
<bytebuddy.version>1.14.7</bytebuddy.version> <!-- Version controlled by Hibernate ORM's needs -->
<hibernate-commons-annotations.version>6.0.6.Final</hibernate-commons-annotations.version> <!-- version controlled by Hibernate ORM -->
<hibernate-reactive.version>2.0.6.Final</hibernate-reactive.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe upgrade to HR 2.0.7 while you're at it? It was supposedly the version to use with ORM 6.2.13.Final...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the other dependencies but not this one. Done and thanks!

Copy link
Member

@rsvoboda rsvoboda Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavideD Any idea where this upgrade comes from? Seems strange to upgrade to a new vertx version in a micro of Hibernate Reactive...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, which upgrade? Hibernate Reactive uses Vert.x 4.4 since 2.0.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavideD The one @rsvoboda linked just above: hibernate/hibernate-reactive@163eee7
It's on the 2.0 branch, oddly, and also included in 2.0.7.Final.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a mistake on my part.

This comment has been minimized.

@yrodiere yrodiere changed the title [3.6] Upgrade to Hibernate ORM 6.2.18.Final [3.6] Upgrade to Hibernate ORM 6.2.18.Final and Hibernate Reactive 2.0.7.Final Jan 9, 2024
@gsmet gsmet added this to the 3.6.5 milestone Jan 9, 2024

This comment has been minimized.

This comment has been minimized.

@gsmet gsmet changed the title [3.6] Upgrade to Hibernate ORM 6.2.18.Final and Hibernate Reactive 2.0.7.Final [3.6] Upgrade to Hibernate ORM 6.2.18.Final Jan 9, 2024
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels Jan 9, 2024
@gsmet gsmet force-pushed the 3.6-hibernate-orm-6.2.18 branch from fe052d3 to 0e6a4b3 Compare January 9, 2024 16:29
@gsmet
Copy link
Member Author

gsmet commented Jan 9, 2024

I removed the Hibernate Reactive upgrade for now.

Copy link

quarkus-bot bot commented Jan 9, 2024

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit b1ee3ee into quarkusio:3.6 Jan 9, 2024
62 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants