Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.6] Upgrade to Hibernate ORM 6.2.18.Final #38099

Merged
merged 1 commit into from
Jan 9, 2024
Merged

[3.6] Upgrade to Hibernate ORM 6.2.18.Final #38099

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bom/application/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
<classmate.version>1.5.1</classmate.version>
<!-- When updating, align bytebuddy.version to Hibernate needs as well (just below),
as well as hibernate-orm.version-for-documentation in docs/pom.xml -->
<hibernate-orm.version>6.2.13.Final</hibernate-orm.version>
<hibernate-orm.version>6.2.18.Final</hibernate-orm.version>
<bytebuddy.version>1.14.7</bytebuddy.version> <!-- Version controlled by Hibernate ORM's needs -->
<hibernate-commons-annotations.version>6.0.6.Final</hibernate-commons-annotations.version> <!-- version controlled by Hibernate ORM -->
<hibernate-reactive.version>2.0.6.Final</hibernate-reactive.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe upgrade to HR 2.0.7 while you're at it? It was supposedly the version to use with ORM 6.2.13.Final...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the other dependencies but not this one. Done and thanks!

Copy link
Member

@rsvoboda rsvoboda Jan 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't hibernate/hibernate-reactive@163eee7 problematic as 3.6 branch is using Vert.x 4.4 - https://github.com/quarkusio/quarkus/blob/3.6/bom/application/pom.xml#L121 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavideD Any idea where this upgrade comes from? Seems strange to upgrade to a new vertx version in a micro of Hibernate Reactive...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, which upgrade? Hibernate Reactive uses Vert.x 4.4 since 2.0.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavideD The one @rsvoboda linked just above: hibernate/hibernate-reactive@163eee7
It's on the 2.0 branch, oddly, and also included in 2.0.7.Final.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a mistake on my part.

Expand Down
Loading