-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump OTel 1.39. and instrumentation to 2.5.0 #41521
Conversation
8102e36
to
87a7546
Compare
Will squash the commits after the PR is reviewed as it makes it easy to spot change implications. |
This will depend on SmallRye reactive messaging changes being currently made... Will post PR here, when available. |
This comment has been minimized.
This comment has been minimized.
🎊 PR Preview 72af1d9 has been successfully built and deployed to https://quarkus-pr-main-41521-preview.surge.sh/version/main/guides/
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least we got rid of a bunch of code :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ sorry you have had to deal with all of the changes in these unstable components. it looks like most of the remaining unstable dependencies are related to DB, RPC and messaging semconv. I think DB and messaging semconv will be stable by end of the year, and we will start working on RPC semconv stability in the next few months. In the opentelemetry-java-instrumentation repo we are currently planning to bump from 2.x to 3.x once we are ready to switch over to stable semconv for all three (DB, RPC and messaging) by default. I noticed that you followed the opt-in flag for http which is awesome, but I would definitely understand if you didn't go through that for future updates since it's quite painful unless you are getting pushback on this from your users (in general we haven't had too much expectation of libraries emitting native instrumentation before the related semconv is stabilized).
@@ -104,7 +100,7 @@ | |||
</dependency> | |||
<dependency> | |||
<groupId>io.opentelemetry</groupId> | |||
<artifactId>opentelemetry-api-events</artifactId> | |||
<artifactId>opentelemetry-api-incubator</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you use this module for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to reset for tests the GlobalEventLoggerProvider
otherwise it throws an error when we execute dev mode. I remember that native would also failed without it.
It's usage comes from the SDK Autoconfiguration.
.../runtime/src/main/java/io/quarkus/opentelemetry/runtime/tracing/cdi/WithSpanInterceptor.java
Show resolved
Hide resolved
@brunobat I let you squash and merge when you're ready. |
I think I will hold until metrics is merged. |
Depends on smallrye/smallrye-reactive-messaging#2677 |
bdd75ac
to
97f329e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
3015c1d
to
59cdeca
Compare
Status for workflow
|
This comment has been minimized.
This comment has been minimized.
59cdeca
to
e03fc20
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs rebasing for version change
e03fc20
to
b6f5499
Compare
Status for workflow
|
BREAKING CHANGES.
This updates the opentelemetry-java bom from 1.32 to 1.39 and the opentelemetry-instrumentation alpha bom from 1.32 to 2.50.
The breaking changes for the users are:
quarkus.otel.semconv-stability.opt-in
system property was removed because users cannot opt-in anymore;io.opentelemetry.extension.annotations.WithSpan
has been removed. Please use the newio.opentelemetry.instrumentation.annotations.WithSpan
, as previously announced.For later:
grpc
tohttp/protobuf
in order to align with the specification. See Change default OpenTelemetry protocol tohttp/protobuf
#41522Other things to look at:
@WithSpan
legacy annotation.quarkus.otel.semconv-stability.opt-in
system property. This will speed up tests considerably.For more details please check:
https://github.com/open-telemetry/opentelemetry-java/blob/main/CHANGELOG.md
https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/CHANGELOG.md