Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OTel instrumentation to 2.5.0 #2677

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

brunobat
Copy link
Contributor

@brunobat brunobat commented Jul 3, 2024

Breaking changes.
For details see: quarkusio/quarkus#41521

@brunobat
Copy link
Contributor Author

brunobat commented Jul 3, 2024

@ozangunalp leaving this draft here because I was having problems with the pulsar image locally and also I get a test error that looks unrelated:
SqsClientConfigTest.testRegionConfigMissing:22 Expecting code to raise a throwable.

@brunobat
Copy link
Contributor Author

brunobat commented Jul 3, 2024

@ozangunalp I have no idea if these build errors are relevant for the PR.

@brunobat brunobat marked this pull request as ready for review July 3, 2024 14:36
@ozangunalp ozangunalp force-pushed the bump-otel-instr-2-5 branch from 50e205a to 7bad192 Compare July 3, 2024 15:38
@ozangunalp
Copy link
Collaborator

That was just the documentation module which provides a sample connector with tracing integration. I've pushed a fix.

@brunobat
Copy link
Contributor Author

brunobat commented Jul 8, 2024

@ozangunalp do you think this is good to go?

@ozangunalp
Copy link
Collaborator

Is it ok if we release 4.22.0 without this one and include it in 4.23 ?

@brunobat
Copy link
Contributor Author

brunobat commented Jul 8, 2024

It depends when you want to have this merged on Quarkus... I'm not sure either.
When do you think 4.23 can go in?

@ozangunalp
Copy link
Collaborator

Ideally, we can cut 4.23 just after with only the OTel update.

@brunobat
Copy link
Contributor Author

brunobat commented Jul 9, 2024

When do you think that can happen?

@gsmet
Copy link

gsmet commented Jul 11, 2024

Ideally, I think we would need this upgrade merged in Quarkus by next Tuesday.

Which means we need the release to happen very very soon (release time + CI time).

@ozangunalp ozangunalp force-pushed the bump-otel-instr-2-5 branch from 7bad192 to 7375421 Compare July 12, 2024 00:09
@ozangunalp ozangunalp added this to the 4.23.0 milestone Jul 12, 2024
@ozangunalp
Copy link
Collaborator

Rebased this on top the 4.22.0 release.

If I am not mistaken this means RM will be incompatible with OTel 1.x.
I'll release 4.23.0 to include only this PR.

@brunobat
Copy link
Contributor Author

Rebased this on top the 4.22.0 release.

If I am not mistaken this means RM will be incompatible with OTel 1.x. I'll release 4.23.0 to include only this PR.

Yes, this is a Breaking Change for the OTel side. IT should be on the release notes.

@ozangunalp ozangunalp merged commit 30852c8 into smallrye:main Jul 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants