Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS support for Vue3 branch and add configuration for the codebase TS migration #7989

Merged
merged 3 commits into from
Dec 2, 2020

Conversation

IlCallo
Copy link
Member

@IlCallo IlCallo commented Nov 3, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Currently the TS rollup plugin will complain when yarn build is run as it doesn't find any TS file, but it finishes the build successfully.

I removed fork-ts-checker version management as v4 doesn't support Vue3 anyway, so we must use v5+
At least in v6 (currently in alpha, I updated to v5 in the meantime) there should be some kind of integrated performance tracker to identify where is the edge case problem I discovered last time I tried the upgrade

Before releasing Quasar 2 it's vital to convert at least 2-3 components/mixins/directives/plugin to composition-api + TS to spot edge cases which would require breaking changes, otherwise we could end up "wasting" a major release.
I already did it with a component and mixin on yusuf test repo and documented the procedure, I can port the changes and convert some more when this PR is merged

@IlCallo IlCallo mentioned this pull request Nov 18, 2020
15 tasks
@rstoenescu rstoenescu merged commit e5fbd7d into quasarframework:vue3-work Dec 2, 2020
@IlCallo IlCallo deleted the vue3-ts-support branch December 2, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants