Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Union{} corner case in isiterabletable #21

Merged
merged 3 commits into from
Apr 1, 2021
Merged

Fix Union{} corner case in isiterabletable #21

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c16a127
Fix Union{} corner case in isiterabletable
bkamins Sep 16, 2020
64e91a1
Fix formatting
davidanthoff Apr 1, 2021
e8dcbc7
Add a test
davidanthoff Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/TableTraits.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,11 @@ function isiterabletable(x::T) where {T}

if Base.IteratorEltype(x)==Base.HasEltype()
et = Base.eltype(x)
if et <: NamedTuple
if et === Union{}
return false
elseif et <: NamedTuple
return true
elseif et===Any
elseif et === Any
return missing
else
return false
Expand Down