-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Union{} corner case in isiterabletable #21
Conversation
This is a corner case as `Union{} <: NamedTuple` but I guess you do not want to support `Union{}` eltype to be `true` in this test?
@davidanthoff - is this OK for you? |
@davidanthoff - is is OK to be merged? |
I think I don't fully understand how we could end up in this situation. Does it make sense for something to return |
See the linked issue in Tables.jl for details. The offending test is for |
It would be great if it could be merged (or rejected) and if it is merged - a new release of TableTraits.jl was tagged. Thank you! |
Is there any decision on this issue? |
Sorry that this took so long, I had to just give up on certain topics in the fall, too many things going on at work :) I'm merging this as soon as tests pass and will then tag a patch release. |
Thank you! |
This is a corner case as
Union{} <: NamedTuple
but I guess you do not want to supportUnion{}
eltype to betrue
in this test?