-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rustls to 0.23 and ring to 0.17 #1715
Conversation
I think you might also change the code in directory rustls::Certificate has been replaced with CertificateDer from the new rustls-pki-types crate. The code in examples does not compile. |
@getong there is a reason the PR is in draft state. |
In order to make ring support some architectures, I hope to upgrade ring to 0.17 as soon as possible |
This comment was marked as outdated.
This comment was marked as outdated.
anything i'm missing? |
No, this was my mistake. I forgot Quinn also has ring in its public API and didn't take the breaking change to update to 0.17 in the 0.10 release like Rustls did. Sorry for the confusion. There is a change required in this repo to remove ring 0.16 from the requirements. |
Made a deep pass; looks like only some minor cosmetic issues left. |
In preparation for allowing IP server names (with rustls 0.23).
702eaca
to
39a45d4
Compare
@Ralith I think this is ready for another round -- hoping it will be the last one! |
Co-authored-by: gabrik <gabriele.baldoni@gmail.com>
Signed-off-by: gabrik <gabriele.baldoni@gmail.com>
Release progress is tracked in #1737. |
No description provided.