Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rustls-native-certs with rustls-platform-verifier #1734

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

Ralith
Copy link
Collaborator

@Ralith Ralith commented Jan 4, 2024

rustls-platform-verifier doesn't seem to support rustls 0.22 yet, so we might want to hold off on this in the hopes of not complicating #1715. Still, long-term, this seems like a safer default to promote.

@Ralith
Copy link
Collaborator Author

Ralith commented Jan 4, 2024

Looks like upstream is missing FreeBSD support :(

@Ralith Ralith marked this pull request as draft January 4, 2024 10:50
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think rustls-platform-verifier 0.2 will be coming along soon enough.

@djc djc mentioned this pull request Jan 12, 2024
7 tasks
@Ralith
Copy link
Collaborator Author

Ralith commented Jan 12, 2024

FreeBSD support will be included in the next upstream release, which will probably also bump to rustls 0.22.

@cpu
Copy link
Contributor

cpu commented Jan 12, 2024

the next upstream release, which will probably also bump to rustls 0.22.

@Ralith We're planning to do a rustls-platform-verifier 0.1.1 release w/ FreeBSD support and Rustls 0.21 separate from the 0.2.0 release with Rustls 0.22. There's an important consumer of the library that will be on Rustls 0.21 for a while so the 0.1.x release tree will be maintained for a decent amount of time.

@complexspaces
Copy link

@Ralith 0.1.1 is now out and released 👍

@Ralith Ralith marked this pull request as ready for review January 18, 2024 01:03
@djc djc merged commit b5dd5a9 into main Jan 18, 2024
8 checks passed
@djc djc deleted the platform-verifier branch January 18, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants