feat(pallet): follow psp22 standard for decrease_allowance and burn
#310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# This is the 1st commit message: refactor: general # This is the commit message #2: init # This is the commit message #3: begin refactor # This is the commit message #4: refactor: error handling # This is the commit message #5: tests: add error handling tests # This is the commit message #6: WIP # This is the commit message #7: finalise error handling # This is the commit message #8: refactor: easier review
Co-authored-by: Frank Bell <frank@r0gue.io>
…sp2_burn' into chungquantin/feat-psp2_burn
chungquantin
changed the base branch from
main
to
chungquantin/main-psp22_pallet
chungquantin
merged commit b31db97
into
chungquantin/main-psp22_pallet
4 of 5 checks passed
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## chungquantin/main-psp22_pallet #310 +/- ##
==================================================================
+ Coverage 51.47% 51.52% +0.05%
==================================================================
Files 48 48
Lines 4894 4902 +8
Branches 4894 4902 +8
==================================================================
+ Hits 2519 2526 +7
- Misses 2326 2327 +1
Partials 49 49
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.