Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add pop api documentation #74

Merged
merged 5 commits into from
May 5, 2024

edit according to PR review comments

0221f55
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

docs: add pop api documentation #74

edit according to PR review comments
0221f55
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded May 2, 2024 in 1s

clippy

5 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 5
Note 0
Help 0

Versions

  • rustc 1.78.0 (9b00956e5 2024-04-29)
  • cargo 1.78.0 (54d8815d0 2024-03-26)
  • clippy 0.1.78 (9b00956 2024-04-29)

Annotations

Check warning on line 49 in node/src/cli.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

large size difference between variants

warning: large size difference between variants
  --> node/src/cli.rs:5:1
   |
5  | / pub enum Subcommand {
6  | |     /// Build a chain specification.
7  | |     BuildSpec(sc_cli::BuildSpecCmd),
8  | |
...  |
19 | |     ImportBlocks(sc_cli::ImportBlocksCmd),
   | |     ------------------------------------- the second-largest variant contains at least 240 bytes
...  |
39 | |     Benchmark(frame_benchmarking_cli::BenchmarkCmd),
   | |     ----------------------------------------------- the largest variant contains at least 512 bytes
...  |
48 | |     Key(sc_cli::KeySubcommand),
49 | | }
   | |_^ the entire enum is at least 512 bytes
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
   = note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
   |
39 |     Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>),
   |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 44 in runtime/testnet/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

bound is defined in more than one place

warning: bound is defined in more than one place
  --> runtime/testnet/src/extensions.rs:44:10
   |
44 |     fn call<E: Ext>(&mut self, env: Environment<E, InitState>) -> Result<RetVal, DispatchError>
   |             ^
45 |     where
46 |         E: Ext<T = T>,
   |         ^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
   = note: `#[warn(clippy::multiple_bound_locations)]` on by default

Check warning on line 49 in runtime/devnet/src/extensions.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

bound is defined in more than one place

warning: bound is defined in more than one place
  --> runtime/devnet/src/extensions.rs:49:10
   |
49 |     fn call<E: Ext>(&mut self, env: Environment<E, InitState>) -> Result<RetVal, DispatchError>
   |             ^
50 |     where
51 |         E: Ext<T = T>,
   |         ^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
   = note: `#[warn(clippy::multiple_bound_locations)]` on by default

Check warning on line 54 in scripts/fund-dev-accounts/./main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used a field initializer for a tuple struct

warning: used a field initializer for a tuple struct
  --> scripts/fund-dev-accounts/./main.rs:54:9
   |
54 |                 id: AssetId { 0: Location { parents: 0, interior: Junctions::Here } },
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `AssetId(Location { parents: 0, interior: Junctions::Here })`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#init_numbered_fields

Check warning on line 57 in scripts/fund-dev-accounts/./main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

used a field initializer for a tuple struct

warning: used a field initializer for a tuple struct
  --> scripts/fund-dev-accounts/./main.rs:52:36
   |
52 |           let assets = VersionedAssets::V4(Assets {
   |  __________________________________________^
53 | |             0: vec![Asset {
54 | |                 id: AssetId { 0: Location { parents: 0, interior: Junctions::Here } },
55 | |                 fun: amount,
56 | |             }],
57 | |         });
   | |_________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#init_numbered_fields
   = note: `#[warn(clippy::init_numbered_fields)]` on by default
help: try
   |
52 ~         let assets = VersionedAssets::V4(Assets(<[_]>::into_vec(
53 +             // This rustc_box is not required, but it produces a dramatic improvement in compile
54 +             // time when constructing arrays with many elements.
55 +             #[rustc_box]
56 +             $crate::boxed::Box::new([$($x),+])
57 ~         )));
   |