Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions #219

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Bump versions #219

merged 1 commit into from
Sep 21, 2023

Conversation

lukebakken
Copy link
Contributor

Golang 1.19 is no longer supported.

@lukebakken lukebakken self-assigned this Sep 8, 2023
@lukebakken lukebakken added this to the 1.9.0 milestone Sep 8, 2023
@lukebakken lukebakken force-pushed the lukebakken/update-versions branch from f032e8c to 329b4bc Compare September 12, 2023 11:34
Copy link
Contributor

@Zerpet Zerpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I added the aliases oldstable and stable to our setup-go action; those use the last two supported Go versions (following Go support policy).

We seem to have a consistent failure in TestIntegrationTxCommit in Windows 🤔

https://github.com/rabbitmq/amqp091-go/actions/runs/6159898205/job/16715641627#step:6:247

@lukebakken are you able to reproduce this locally? This is passing for me consistently on MacOS

Edit: feel free to revert my commit if you prefer to keep pinned versions of Go minor versions

@lukebakken
Copy link
Contributor Author

@Zerpet yes that failure is known and @acogoluegnes is fixing it here:

rabbitmq/rabbitmq-server#9318

I think I'll downgrade the version of RMQ used for testing for now, but I would like us to test client libs with the latest supported RMQ versions and upcoming betas.

@lukebakken lukebakken force-pushed the lukebakken/update-versions branch from 21d0c14 to 17fda21 Compare September 21, 2023 02:54
Golang 1.19 is no longer supported.

Usa oldstable and stable aliases

Since actions/setup-go v3, we can use oldstable and
stable aliases to always refer to the two latest supported
versions of Go.

Signed-off-by: Aitor Perez Cedres <acedres@vmware.com>
@lukebakken lukebakken force-pushed the lukebakken/update-versions branch from 17fda21 to 0f3be01 Compare September 21, 2023 02:55
@lukebakken lukebakken merged commit 97a7db0 into main Sep 21, 2023
7 checks passed
@lukebakken lukebakken deleted the lukebakken/update-versions branch September 21, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants