-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests after mc merge #9318
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acogoluegnes
force-pushed
the
mc-fixes
branch
2 times, most recently
from
September 11, 2023 07:01
99d8cb2
to
5a714ea
Compare
acogoluegnes
force-pushed
the
mc-fixes
branch
3 times, most recently
from
September 18, 2023 15:08
2a133ec
to
387bd7c
Compare
Following up on failures detected by Java project test suites after the merge of the message container PR. These tests are ported to Erlang in the broker test suite.
To return a 406 error code (pre-condition failed).
To avoid mutating the message. See https://rabbitmq.com/dlx.html#effects
Just before publish confirms, to make sure basic.return is sent when the transaction is committed, not when the message is published.
Applies only to 3.13.
acogoluegnes
force-pushed
the
mc-fixes
branch
from
September 18, 2023 16:33
7b0fe9f
to
dba1e17
Compare
kjnilsson
approved these changes
Sep 19, 2023
Merged
lukebakken
reviewed
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on failures detected by Java project test suites after the merge of the message container PR. These tests are ported to Erlang in the broker test suite.