Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move selenium to root #12198

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Move selenium to root #12198

merged 2 commits into from
Sep 4, 2024

Conversation

MarcialRosales
Copy link
Contributor

@MarcialRosales MarcialRosales commented Sep 3, 2024

Proposed Changes

Selenium tests are end-to-end tests. They currently verify two kind of functionality:

  • management ui
  • messaging protocols authenticating with multiple authentication backends

These tests have lived under deps/rabbitmq-management/selenium folder because they were initially meant for testing the management ui. But now, they are used to test other areas not only the management ui. Therefore, it is more appropriate that these tests live somewhere else, like in the root of this rabbitmq-server repository.

Additionally, the Gihub action that runs the management ui tests have been split into two GHA. One for push to main and another for PRs.

Note: This PR depends on #12165

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

@mergify mergify bot added the make label Sep 3, 2024
@MarcialRosales MarcialRosales changed the base branch from main to run-selenium-on-cluster September 3, 2024 10:23
@MarcialRosales MarcialRosales self-assigned this Sep 3, 2024
@MarcialRosales MarcialRosales force-pushed the run-selenium-on-cluster branch from 3e85ae6 to e62a470 Compare September 3, 2024 16:54
@MarcialRosales MarcialRosales force-pushed the run-selenium-on-cluster branch from e62a470 to 77b63d6 Compare September 4, 2024 09:07
@MarcialRosales MarcialRosales marked this pull request as ready for review September 4, 2024 12:24
Base automatically changed from run-selenium-on-cluster to main September 4, 2024 15:14
@michaelklishin michaelklishin merged commit 654fb75 into main Sep 4, 2024
241 checks passed
@michaelklishin michaelklishin deleted the move-selenium-to-root branch September 4, 2024 15:53
@mergify mergify bot mentioned this pull request Sep 4, 2024
6 tasks
MarcialRosales added a commit that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants