Move selenium to root (backport #12198) #12213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
|
Cherry-pick of a1206dc has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
(cherry picked from commit a1206dc) # Conflicts: # .github/workflows/test-management-ui.yaml # selenium/bin/components/rabbitmq # selenium/bin/rabbit-compose.yml # selenium/test/authnz-msg-protocols/rabbitmq.cluster.conf # selenium/test/basic-auth/rabbitmq.cluster.conf # selenium/test/env.cluster # selenium/test/multi-oauth/rabbitmq.cluster.conf # selenium/test/oauth/rabbitmq.cluster.conf # selenium/test/vhosts/Makefile
(cherry picked from commit 94f7540)
MarcialRosales
force-pushed
the
mergify/bp/v4.0.x/pr-12198
branch
from
a45683b to
f5c51d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Selenium tests are end-to-end tests. They currently verify two kind of functionality:
These tests have lived under
deps/rabbitmq-management/seleniumfolder because they were initially meant for testing the management ui. But now, they are used to test other areas not only the management ui. Therefore, it is more appropriate that these tests live somewhere else, like in the root of this rabbitmq-server repository.Additionally, the Gihub action that runs the management ui tests have been split into two GHA. One for push to main and another for PRs.
Note: This PR depends on #12165
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyThis is an automatic backport of pull request #12198 done by [Mergify](https://mergify.com).