Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify code #9456

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Simplify code #9456

merged 1 commit into from
Sep 19, 2023

Conversation

ansd
Copy link
Member

@ansd ansd commented Sep 19, 2023 •
edited
Loading

  1. Remove unnecessary default value false
  2. Do not pass the mandatory option to queues since queues do not make use of that option. It's merely used in the channel.

Follow up of #9318

@ansd
Simplify code
741eb3e 
1. Do not pass the mandatory option to queues since queues do not make
   use of that option. It's merely used in the channel.
2. Remove unnecessary default value 'false'
@ansd ansd marked this pull request as ready for review September 19, 2023 10:19
@ansd ansd requested a review from acogoluegnes September 19, 2023 10:19
@kjnilsson kjnilsson merged commit 8ce9db6 into main Sep 19, 2023
12 checks passed
@kjnilsson kjnilsson deleted the channel-mandatory branch September 19, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjnilsson kjnilsson kjnilsson approved these changes

@acogoluegnes acogoluegnes Awaiting requested review from acogoluegnes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ansd @kjnilsson