Enable completion based on trait bounds only for FnArg #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TedDriggs
previously requested changes
Jun 14, 2018
| @@ -1,5 +1,5 @@ | |||
| #![feature(iterator_flatten)] | |||
There was a problem hiding this comment.
Doesn't this mean racer stops working on stable? If so, please use something from itertools or a hand-rolled function instead.
There was a problem hiding this comment.
By #854, now we have to use nightly to compile racer so I don't think it's problematic.
iterator_flatten will soon be stabilized(see rust-lang/rust#51511), but it'll take much more time to stabilize libsyntax.
kngwyu
dismissed
TedDriggs’s stale review
By #854, now we have to use nightly to compile racer so I don't think it's problematic.
kngwyu
added a commit
that referenced
this pull request
Jun 17, 2018
I forgot remove #[ignore] from completes_inherited_methods_with_cycle when I was working on #871
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebump of #828