Stabilize Iterator::flatten in 1.29, fixes #48213. #51511

Centril · 2018-06-11T21:15:25Z

This PR stabilizes Iterator::flatten in version 1.29 (1.28 goes to beta in 10 days, I don't think there's enough time to land it in that time, but let's see...).

Tracking issue is: #48213.

cc @bluss re. itertools.
r? @SimonSapin
ping @pietroalbini -- let's do a crater run when this passes CI :)

SimonSapin · 2018-06-11T21:21:59Z

@bors try

There was some concern on the tracking issue about colliding with the itertools crate, so let’s so a check-only crater run before landing.

bors · 2018-06-11T21:22:10Z

⌛ Trying commit 85796dd with merge b534f2e...

@bluss

…<try> Stabilize Iterator::flatten in 1.29, fixes #48213. This PR stabilizes [`Iterator::flatten`](https://doc.rust-lang.org/nightly/std/iter/trait.Iterator.html#method.flatten) in *version 1.29* (1.28 goes to beta in 10 days, I don't think there's enough time to land it in that time, but let's see...). Tracking issue is: #48213. cc @bluss re. itertools. r? @SimonSapin ping @pietroalbini -- let's do a crater run when this passes CI :)

bors · 2018-06-11T23:03:21Z

☀️ Test successful - status-travis
State: approved= try=True

pietroalbini · 2018-06-11T23:15:11Z

Check-only crater run started on crater-2. It should be done in ~3 days.

pietroalbini · 2018-06-14T09:36:23Z

Hi @Centril (crater requester), @SimonSapin (PR reviewer)! Crater results are at: http://cargobomb-reports.s3.amazonaws.com/pr-51511/index.html. 'Blacklisted' crates (spurious failures etc) can be found here. If you see any spurious failures not on the list, please make a PR against that file.

(interested observers: Crater is a tool for testing the impact of changes on the crates.io ecosystem. You can find out more at the repo if you're curious)

pietroalbini · 2018-06-14T09:53:41Z

Only 11 top level regressions (and 29 counting dependencies), I expected worse. Note that crater detects only crates that build in the crater environment successfully, so this is not the whole ecosystem.

Failure dependency graph

Note: all the libimag* failures seems to be caused by libimagrt, the tool I use to generate the graph is a bit flacky though so the tree is not properly ordered.

bolt11
libimagref
| imag-documentation
rust-bio-tools
libimagrt
| libimagentryedit
| | libimagentryview
| | | libimagdiary
| | | | libimaglog
| | libimagnotes
| | libimaghabit
| imag-counter
libimagentryref
| libimagmail
libimagcontact
irc-bot
mhost
httptin
git-checks
difference_engine
gurobi
github:lukaspustina/mhost
github:vwilliewillus/advent_of_code_2017

Centril · 2018-06-14T15:23:17Z

Doesn't seem insurmountable :) I'll start writing up PRs against the regressing crates.

…ust-lang/rust#51511

Centril · 2018-06-14T15:40:57Z

imag fixed the regression in https://github.com/matthiasbeyer/imag/pull/1491 but hasn't made a 0.9 release yet.

The same applies to irc-bot 0.2, 8573/irc-bot.rs@dfebfd4.

I've notified the authors of this.

Centril · 2018-06-14T16:13:32Z

PRs against httpin here:

PR against rust-git-checks here:

https://gitlab.kitware.com/utils/rust-git-checks/merge_requests/112

Centril · 2018-06-14T16:39:39Z

The regression in https://github.com/williewillus/advent_of_code_2017 was due to a regression in pathfinding which was fixed in evenfurther/pathfinding@eb7a947.

This was the last regressing crate.

bors · 2018-06-30T03:11:00Z

@Centril: 🔑 Insufficient privileges: Not in reviewers

Mark-Simulacrum · 2018-06-30T03:13:48Z

@bors r=SimonSapin

bors · 2018-06-30T03:13:49Z

📌 Commit 85796dd has been approved by SimonSapin

bors · 2018-06-30T06:03:10Z

⌛ Testing commit 85796dd with merge 9b704901f62cf0cf4fadba4ae8aa7b6de5f64f30...

bors · 2018-06-30T06:06:08Z

💔 Test failed - status-travis

rust-highfive · 2018-06-30T06:06:09Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-06-30T06:06:14Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2018-06-30T06:40:32Z

@bors retry rollup

Travis failed to schedule several macOS builders.

@bluss

…flatten, r=SimonSapin Stabilize Iterator::flatten in 1.29, fixes rust-lang#48213. This PR stabilizes [`Iterator::flatten`](https://doc.rust-lang.org/nightly/std/iter/trait.Iterator.html#method.flatten) in *version 1.29* (1.28 goes to beta in 10 days, I don't think there's enough time to land it in that time, but let's see...). Tracking issue is: rust-lang#48213. cc @bluss re. itertools. r? @SimonSapin ping @pietroalbini -- let's do a crater run when this passes CI :)

@bluss

…flatten, r=SimonSapin Stabilize Iterator::flatten in 1.29, fixes rust-lang#48213. This PR stabilizes [`Iterator::flatten`](https://doc.rust-lang.org/nightly/std/iter/trait.Iterator.html#method.flatten) in *version 1.29* (1.28 goes to beta in 10 days, I don't think there's enough time to land it in that time, but let's see...). Tracking issue is: rust-lang#48213. cc @bluss re. itertools. r? @SimonSapin ping @pietroalbini -- let's do a crater run when this passes CI :)

@ghost

Rollup of 7 pull requests Successful merges: - #51511 (Stabilize Iterator::flatten in 1.29, fixes #48213.) - #51853 (Fix some doc links) - #51890 (Fix inconsequential typo in GlobalAlloc doc example) - #51920 (use literal span for concrete type suggestion) - #51922 (rename the llvm-tools component to llvm-tools-preview and tweak its image) - #51936 (rename rustc's lld to rust-lld) - #51961 (Fix typo in /src/librustc_resolve/lib.rs) Failed merges: r? @ghost

@bluss

…flatten, r=SimonSapin Stabilize Iterator::flatten in 1.29, fixes rust-lang#48213. This PR stabilizes [`Iterator::flatten`](https://doc.rust-lang.org/nightly/std/iter/trait.Iterator.html#method.flatten) in *version 1.29* (1.28 goes to beta in 10 days, I don't think there's enough time to land it in that time, but let's see...). Tracking issue is: rust-lang#48213. cc @bluss re. itertools. r? @SimonSapin ping @pietroalbini -- let's do a crater run when this passes CI :)

@ghost

Rollup of 7 pull requests Successful merges: - #51511 (Stabilize Iterator::flatten in 1.29, fixes #48213.) - #51853 (Fix some doc links) - #51890 (Fix inconsequential typo in GlobalAlloc doc example) - #51920 (use literal span for concrete type suggestion) - #51921 (improve the error message when `#[panic_implementation]` is missing) - #51922 (rename the llvm-tools component to llvm-tools-preview and tweak its image) - #51961 (Fix typo in /src/librustc_resolve/lib.rs) Failed merges: r? @ghost

Version 1.29.0 (2018-09-13) ========================== Compiler -------- - [Bumped minimum LLVM version to 5.0.][51899] - [Added `powerpc64le-unknown-linux-musl` target.][51619] - [Added `aarch64-unknown-hermit` and `x86_64-unknown-hermit` targets.][52861] Libraries --------- - [`Once::call_once` now no longer requires `Once` to be `'static`.][52239] - [`BuildHasherDefault` now implements `PartialEq` and `Eq`.][52402] - [`Box<CStr>`, `Box<OsStr>`, and `Box<Path>` now implement `Clone`.][51912] - [Implemented `PartialEq<&str>` for `OsString` and `PartialEq<OsString>` for `&str`.][51178] - [`Cell<T>` now allows `T` to be unsized.][50494] - [`SocketAddr` is now stable on Redox.][52656] Stabilized APIs --------------- - [`Arc::downcast`] - [`Iterator::flatten`] - [`Rc::downcast`] Cargo ----- - [Cargo can silently fix some bad lockfiles ][cargo/5831] You can use `--locked` to disable this behaviour. - [`cargo-install` will now allow you to cross compile an install using `--target`][cargo/5614] - [Added the `cargo-fix` subcommand to automatically move project code from 2015 edition to 2018.][cargo/5723] Misc ---- - [`rustdoc` now has the `--cap-lints` option which demotes all lints above the specified level to that level.][52354] For example `--cap-lints warn` will demote `deny` and `forbid` lints to `warn`. - [`rustc` and `rustdoc` will now have the exit code of `1` if compilation fails, and `101` if there is a panic.][52197] - [A preview of clippy has been made available through rustup.][51122] You can install the preview with `rustup component add clippy-preview` Compatibility Notes ------------------- - [`str::{slice_unchecked, slice_unchecked_mut}` are now deprecated.][51807] Use `str::get_unchecked(begin..end)` instead. - [`std::env::home_dir` is now deprecated for its unintuitive behaviour.][51656] Consider using the `home_dir` function from https://crates.io/crates/dirs instead. - [`rustc` will no longer silently ignore invalid data in target spec.][52330] [52861]: rust-lang/rust#52861 [52656]: rust-lang/rust#52656 [52239]: rust-lang/rust#52239 [52330]: rust-lang/rust#52330 [52354]: rust-lang/rust#52354 [52402]: rust-lang/rust#52402 [52103]: rust-lang/rust#52103 [52197]: rust-lang/rust#52197 [51807]: rust-lang/rust#51807 [51899]: rust-lang/rust#51899 [51912]: rust-lang/rust#51912 [51511]: rust-lang/rust#51511 [51619]: rust-lang/rust#51619 [51656]: rust-lang/rust#51656 [51178]: rust-lang/rust#51178 [51122]: rust-lang/rust#51122 [50494]: rust-lang/rust#50494 [cargo/5614]: rust-lang/cargo#5614 [cargo/5723]: rust-lang/cargo#5723 [cargo/5831]: rust-lang/cargo#5831 [`Arc::downcast`]: https://doc.rust-lang.org/std/sync/struct.Arc.html#method.downcast [`Iterator::flatten`]: https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.flatten [`Rc::downcast`]: https://doc.rust-lang.org/std/rc/struct.Rc.html#method.downcast

stabilize Iterator::flatten in 1.29, fixes rust-lang#48115.

85796dd

Centril added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. A-iterators Area: Iterators labels Jun 11, 2018

rust-highfive assigned SimonSapin Jun 11, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 11, 2018

pietroalbini added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Jun 11, 2018

Centril changed the title ~~Stabilize Iterator::flatten in 1.29, fixes #48115.~~ Stabilize Iterator::flatten in 1.29, fixes #48213. Jun 11, 2018

kngwyu mentioned this pull request Jun 14, 2018

Enable completion based on trait bounds only for FnArg racer-rust/racer#871

Merged

pietroalbini removed the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Jun 14, 2018

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 14, 2018

Centril added a commit to Centril/bolt11-rust that referenced this pull request Jun 14, 2018

Fix nightly regression due to stabilization of Iterator::flatten, see r…

cb0f1c3

…ust-lang/rust#51511

Centril mentioned this pull request Jun 14, 2018

Fix nightly regression due to stabilization of Iterator::flatten kronolynx/bolt11-rust#1

Merged

This was referenced Jun 14, 2018

Fix Itertools::flatten regression in nightly rust-bio/rust-bio-tools#6

Merged

Iterator::flatten is pending stabilization 8573/irc-bot.rs#31

Closed

Fix regression due to pending stabilization of Iterator::flatten lukaspustina/mhost#12

Merged

This was referenced Jun 14, 2018

Fix regression due to pending stabilization of Iterator::flatten pthariensflame/difference_engine#1

Merged

Fix Itertools::flatten regression soon in nightly. ubnt-intrepid/rust-gurobi#41

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 30, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2018

kennytm mentioned this pull request Jun 30, 2018

Rollup of 9 pull requests #51948

Closed

pietroalbini mentioned this pull request Jul 1, 2018

Rollup of 7 pull requests #51965

Closed

pietroalbini mentioned this pull request Jul 1, 2018

Rollup of 7 pull requests #51969

Merged

bors merged commit 85796dd into rust-lang:master Jul 1, 2018

Centril deleted the feature/stabilize_iterator_flatten branch July 3, 2018 01:18

Centril mentioned this pull request Aug 28, 2018

stabilize slice_align_to #53754

Merged

phansch mentioned this pull request Sep 17, 2018

facing issue while make with Rust version 1.29.0 for ethstore v0.2.0 omni/poa-bridge#118

Open

lcdr mentioned this pull request Mar 8, 2020

RFC: Supertrait item shadowing rust-lang/rfcs#2845

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize Iterator::flatten in 1.29, fixes #48213. #51511

Stabilize Iterator::flatten in 1.29, fixes #48213. #51511

Centril commented Jun 11, 2018 •

edited

Loading

SimonSapin commented Jun 11, 2018

bors commented Jun 11, 2018

bors commented Jun 11, 2018

pietroalbini commented Jun 11, 2018

pietroalbini commented Jun 14, 2018

pietroalbini commented Jun 14, 2018 •

edited

Loading

Centril commented Jun 14, 2018

Centril commented Jun 14, 2018 •

edited

Loading

Centril commented Jun 14, 2018 •

edited

Loading

Centril commented Jun 14, 2018

bors commented Jun 30, 2018

Mark-Simulacrum commented Jun 30, 2018

bors commented Jun 30, 2018

bors commented Jun 30, 2018

bors commented Jun 30, 2018

rust-highfive commented Jun 30, 2018

rust-highfive commented Jun 30, 2018

kennytm commented Jun 30, 2018

Stabilize Iterator::flatten in 1.29, fixes #48213. #51511

Stabilize Iterator::flatten in 1.29, fixes #48213. #51511

Conversation

Centril commented Jun 11, 2018 • edited Loading

SimonSapin commented Jun 11, 2018

bors commented Jun 11, 2018

bors commented Jun 11, 2018

pietroalbini commented Jun 11, 2018

pietroalbini commented Jun 14, 2018

pietroalbini commented Jun 14, 2018 • edited Loading

Centril commented Jun 14, 2018

Centril commented Jun 14, 2018 • edited Loading

Centril commented Jun 14, 2018 • edited Loading

Centril commented Jun 14, 2018

bors commented Jun 30, 2018

Mark-Simulacrum commented Jun 30, 2018

bors commented Jun 30, 2018

bors commented Jun 30, 2018

bors commented Jun 30, 2018

rust-highfive commented Jun 30, 2018

rust-highfive commented Jun 30, 2018

kennytm commented Jun 30, 2018

Centril commented Jun 11, 2018 •

edited

Loading

pietroalbini commented Jun 14, 2018 •

edited

Loading

Centril commented Jun 14, 2018 •

edited

Loading

Centril commented Jun 14, 2018 •

edited

Loading