Gemspec updated #109
Closed
Gemspec updated #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's recommended to not include the Gemfile.lock in a project, see http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/ Also, I declared the development dependencies in the gemspec and just refer to that from the Gemfile. Lastly, I declared two so far undeclared dependencies: thor & git
|
👍 |
This was referenced Apr 24, 2015
Closed
|
Partial dupe of #72 |
perlun
pushed a commit
that referenced
this pull request
Apr 21, 2017
alex-damian-negru
pushed a commit
to alex-damian-negru/rack-test
that referenced
this pull request
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple PRs to update the Gemspec, but they missed that it's generated with Thor. Here an updated version:
Also, it declares all development dependencies (including the missing thor & git) in the gemspec, not the Gemfile & removed the like to the late rubyforge project.