Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #169
Summary
I stopped generating gemspec file from
Thorfile
.That confusing us including contributors.
There is a way to manage gemspec file statically.
Ref:
I created new file lib/rack/test/version.rb newly to manage version string.
Because when I tried to load
require "rack/test"
in the gemspec file , thenbundle install
, that causes install error. When I searched internet (Issue with administrate-field-image thoughtbot/administrate#717), it is related thatrack/test
is recursively loaded. So, I referred above Listen's way.I added Release way to README again because that is useful for people who do release.
You can check modified README here: https://github.com/junaruga/rack-test/blob/feature/stop-generating-gemspec/README.md
I added release test to `.travis.yml. This is because I wanted to test gemspec file and release script.
Detail
"
to single quote'
is to pass rubocop latest version 0.49.0 test. There is one violation error for the rubocop test for here document. But can not avoid it.lib
and some document files.This way removing test files is maybe new popular. For example you can see it on
rails/rails
,rspec/rspec-*
, the merit is we can reduce the file size of gem.gem specification
on Travis CI.I did not see this item at
rais/rails
,rspec-core
.http://guides.rubygems.org/specification-reference/#rubygems_version
Both are same meaning items. But maybe add_runtime_dependency is newer than add_dependency. Seeing
rails/rails
add_dependency is used. So, I used it for the compativility of older Rubies.I also removed/updated those items referring http://guides.rubygems.org/specification-reference/ ,
rails/rails
andrspec/rspec-core
. So, if you have questions, please let me know..travis.yml
Thorfile
$ bundle exec thor :install
itself is not useful. Becausegem install --local pkg/rack-test-*.gem
is run in the Bundler world.How to test