-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate rack-test.gemspec from Thorfile adding license, updating homepage #166
Conversation
3145a30
to
7b29932
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me.
Again, this is an area I think it would be fine to change. I have never encountered a gem before where the gemspec
is maintained via a Thorfile
. It feels unnatural to me. The gemspec
is more a file that you maintain manually, in my book, so I think we could move over to that pattern if you and/or @scepticulous agree. I don't really see the value of having it be machine-generated, when we could just as well let it be the "single source of truth" for its content instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @perlun about potentially removing thor from this equation. However I would actually merge this change the way it is, make the release.
Next we can discuss cleanup and removing things we no longer want/need.
@perlun @scepticulous I agree with you guys.
Yes, I agree the way. |
* Add license. * Update Home Page
7b29932
to
9a7cfa4
Compare
Thanks for the reviewing! |
@@ -1,25 +1,26 @@ | |||
# -*- encoding: utf-8 -*- | |||
# stub: rack-test 0.6.3 ruby lib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line makes no sense. This is autogenerated by RubyGems for .gemspec files used after installation. Moreover, it is not visible on GH, but the separator is null character, not sure what separator is used here ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran thor
command on Ruby 2.2.7 when I generated the gemspec file. The Ruby's RubyGems was used to append the line. Maybe.
Because when I tried it on Ruby 2.4, freeze
string was appended in the gemspec file. and there was so much difference between before and after modification. I did not like the difference.
* Add license. * Update Home Page
Thorfile
. Right now the gemspec file has 2 license parts in the file.Also the license information would be better to be included in
Thorfile
. And the gemspec file should be generated fromThorfile
bythor
command.This fixes Explicitly set license to MIT in .gemspec #130
Thorfile
.I used Ruby 2.2.7 to use
thor
.Because when I used Ruby 2.4, the strings part of the gemfile was generated as
"foo".freeze
.That is hard to check the difference of last modified one.
Below is how to generate.