-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update RTD config, move doc deps into their own group, update dev group #2381
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
codecov failure is a known bug in the current version of the action when creating a PR from a fork - codecov/codecov-action#1487 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2381 +/- ##
=======================================
Coverage 90.18% 90.18%
=======================================
Files 247 247
Lines 15677 15677
=======================================
Hits 14138 14138
Misses 1539 1539 Continue to review full report in Codecov by Sentry.
|
this new job produces outputs that can be used by other jobs to determine if they should run or not making it easier to skip jobs on/from forks that can't run on/from forks.
the PR for this change is stuck waiting for the "Spell Check" workflow to run. this could be caused by the trigger only being defined for pushed events and this being from a fork where actions don't run.
What Changed
Added
info
job to the CI/CD workflowtest-functional
anddeploy-test-infrastructure
jobs as these are unable to run when a PR is opened from a fork because they require secretsChanged
[tool.poetry.dev-dependencies]
table to[tool.poetry.group.dev.dependencies]
poetry >= 1.2.0
(source)main
dependency group into thedocs
dependency group ([tool.poetry.group.docs.dependencies]
table)Makefile
accordingly to remove--extras
flagboto3-stubs
&mypy-boto3
out of thedev
dependency group into thetypes
dependency group to better reflect what they are being installed for--extras docs
Spell Check
workflow will not trigger for pull requests and pushes to themaster
branch rather than only for pushes to all branchesCI/CD
workflowSpell Check
workflow to run/report status as this PR is opened from a fork which does not run actions by default