-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add future.strict_environment
config option
#341
Conversation
macOS failure is likely on GitHub's end, there arn't any logs that that show a fault. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything generally looks great to me here.
I think it'd be good to settle on static
vs strict
in the config & method names, i.e. picking one for consistency (strict seems good to me fwiw)
not sure where static came from... looks like it only got into the docs/docstring though. i'll swap it out. |
Why This Is Needed
resolves #333
What Changed
Added
environments
being defined but the current environment not in the definitionChanged