Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add future.strict_environment config option #341

Merged
merged 10 commits into from
Jun 4, 2020
Merged

add future.strict_environment config option #341

merged 10 commits into from
Jun 4, 2020

Conversation

ITProKyle
Copy link
Collaborator

@ITProKyle ITProKyle commented May 22, 2020

Why This Is Needed

resolves #333

What Changed

Added

  • option for how to handle environments being defined but the current environment not in the definition

Changed

  • log format of skip information no longer includes extra characters and is now prefixed by the module name

@ITProKyle ITProKyle added the feature Request or pull request for a new feature label May 22, 2020
@ITProKyle ITProKyle self-assigned this May 22, 2020
@ITProKyle ITProKyle changed the title "strict" mode add future.strict_environment config option May 27, 2020
@ITProKyle ITProKyle marked this pull request as ready for review May 27, 2020 23:55
@ITProKyle
Copy link
Collaborator Author

macOS failure is likely on GitHub's end, there arn't any logs that that show a fault.

Copy link
Contributor

@troyready troyready left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything generally looks great to me here.

I think it'd be good to settle on static vs strict in the config & method names, i.e. picking one for consistency (strict seems good to me fwiw)

@ITProKyle
Copy link
Collaborator Author

not sure where static came from... looks like it only got into the docs/docstring though. i'll swap it out.

@ITProKyle ITProKyle requested a review from troyready June 4, 2020 20:32
@troyready troyready merged commit ec3fc2f into rackspace:master Jun 4, 2020
@ITProKyle ITProKyle deleted the feature/strict branch June 4, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Request or pull request for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQUEST] deployment/module.environments should be strict
2 participants