Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve test coverage of command base classes #354

Merged
merged 17 commits into from
Jun 8, 2020
Merged

improve test coverage of command base classes #354

merged 17 commits into from
Jun 8, 2020

Conversation

ITProKyle
Copy link
Collaborator

depends on #341 (some logic changes and added tests)

Why This Is Needed

related to #325

What Changed

Added

  • additional unit test

Removed

  • some code that was made redundant/obsolete by the config classes

@ITProKyle ITProKyle added the maintenance General repo or CI/CD upkeep label Jun 4, 2020
@ITProKyle ITProKyle self-assigned this Jun 4, 2020
@ITProKyle ITProKyle requested a review from troyready June 8, 2020 15:50
@ITProKyle ITProKyle marked this pull request as ready for review June 8, 2020 15:50
@troyready troyready merged commit a5bb408 into rackspace:master Jun 8, 2020
@ITProKyle ITProKyle deleted the maint/unittest-cmd-base-classes branch June 8, 2020 16:36
@ITProKyle ITProKyle mentioned this pull request Jun 9, 2020
Merged
troyready pushed a commit that referenced this pull request Jun 9, 2020
@ITProKyle
fix RunwayModule not subscriptable & awacs/troposphere unload causing…
7760402 
… isinstance inconsistencies (#361)

* fix module not subscriptable

introduced in #354

* exclude awacs and troposphere from cfngin sys.modules unload

bug introduced in #351
resolves #360

* update cfngin test with new call args

* add test for sys_module_exclude
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troyready troyready troyready approved these changes

Assignees

@ITProKyle ITProKyle

Labels
maintenance General repo or CI/CD upkeep
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ITProKyle @troyready