Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add message about false alarm pip errors & pip --no-color #346

Closed
wants to merge 1 commit into from
Closed

add message about false alarm pip errors & pip --no-color #346

wants to merge 1 commit into from

Conversation

ITProKyle
Copy link
Collaborator

Why This Is Needed

resolves #345

What Changed

Added

  • notice about false alarm compatibility errors when using pip with the aws_lambda hook

Changed

  • aws_lambda hook will no longer use colorized pip output so its false alarm compatibility errors are less menacing

@ITProKyle ITProKyle added the bug Something isn't working label May 28, 2020
troyready added a commit that referenced this pull request May 29, 2020
troyready added a commit that referenced this pull request May 29, 2020
@troyready
Copy link
Contributor

I had some additional logic I was working on for this -- incorporated it in #350 . I also took a stab at trimming down the log message.

Fine to continue in this PR or that one.

@ITProKyle
Copy link
Collaborator Author

closing in favor of #350

@ITProKyle ITProKyle closed this Jun 4, 2020
@ITProKyle ITProKyle deleted the bugfix/pip-error branch June 4, 2020 16:50
troyready added a commit that referenced this pull request Jun 4, 2020
troyready added a commit that referenced this pull request Jun 4, 2020
* disable pip red error messages; add pip warning

Closes #345
Supersedes #346

* omit too-many-lines check from aws_lambda hook

Don't want to move the internal functions out, and many of the lines are
docs/etc

* add integration test for red pip error message

* Update CHANGELOG.md

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static site Auth@Edge reports a red "ERROR" during lambda builds
2 participants