disable pip red error messages; add pip warning #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ITProKyle
requested changes
May 29, 2020
|
I've taken a first pass at an integration test for the issue. I didn't make the tty invocation stuff more general (not sure yet how much we'd want to use it), but I'd be open to doing it now or later. |
troyready
commented
May 30, 2020
| @@ -1,61 +1,81 @@ | |||
| """Test AWS Lambda hook.""" | |||
There was a problem hiding this comment.
This file is not nearly as changed as the git diff is implying here. The main change is the _build method.
ITProKyle
approved these changes
Jun 4, 2020
Don't want to move the internal functions out, and many of the lines are docs/etc
troyready
force-pushed
the
fix/remove_pip_red_error
branch
from
0ec947f to
4de2968
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #345
Supersedes #346