-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix 6095 increase server_test timeout #6096
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robnagler
reviewed
Jul 11, 2023
@@ -36,7 +36,8 @@ def test_elegant_data_file(fc): | |||
run = fc.sr_post("runStatus", run.nextRequest) | |||
time.sleep(1) | |||
else: | |||
pkunit.pkfail("runStatus: failed to complete: {}", run) | |||
if run.state != "completed": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Increase the timeout, don't do this. It doesn't make sense.
Benbenbenin0
added a commit
that referenced
this pull request
Jul 13, 2023
* Fix #5879 radia cylindrical divisions (#5923) * Fix #5947: move pump_type and rename laser gain tab (#5952) * Fix #5945: add description for thermal lensing (#5957) * fix #5937 omega beam centering and error handling (#5959) * Fix #5944: silas plot units (#5963) Also fixes new drift and lens module names. Replace chirp with tau_0 * fix #5965 omega fixes (#5966) - added default values for simWorkflow - improved layouts - improved genesis error handling * Fix #5931: show error if no epics server on start monitor (#5956) * Fix #5974 radia local cut plane (#5975) * Fix #5974 - adds center to cut point when specified --------- Co-authored-by: mkeilman <mkeilman@radiasoft.net> * fix #3932 include rpnVariables for twissReport cache (#5968) * fix #5414 added more precision and removed quotes from elegant csv output (#5967) * fix #5942 match silas results with notebook (#5964) * Fix #5954: improve silas panel layout (#5960) * Fix #5596 Add file_lock concurrency protection (#5848) * Fix #5596 Add file_lock concurrency protection - Fix #5740 ensure serial greater than incoming and on disk - Fix #5742 restricted critical sections and removed most - Fix #5743 migrate_guest_to_persistent_user locks new and guest uid - Fix #5744 simulation_dir uses lock_user - Fix #5745 validate version in save_simulation_json - Fix #5746 removed lock on auth.unchecked_get_user - Fix #5747 complete_registration passed display_name - Fix #5749 removed auth_db locking, verified all critical sections - Fix #5750 thread locking only in flask - Fix #5751 add auth.create_and_login_user for testing * fix radiasoft/raydata#62: remove unused options (Simulation Documentation URL, Export as Zip, Python Source) in raydata settings submenu (#5891) * Fix #5642 pkuinit.restart_or_fail if `_ping_supervisor` fails (#5643) * fix #5979 fix missing case in plot axis tick formatting (#5987) * Fix #5978: fixed scale bug in hellweg (#5992) * fix #5982 use new hellweg binary output format, gamma vs beta (#5997) * Fix #5983 copy reacts build files into /static (#5984) * fix #5998 improve hellweg source generation, fixed energy scaling (#5999) * Fix #5991 - omit one-time eval (#6006) * Fix #5996: add particles keyword to hellweg (#6001) * Fix #6018 static_files.gen correctly copies react bundle files (#6019) * Fix #5943: error message non premium (#5971) * Fix #5994: make etc/run-jupyterhub.sh work again (#5995) * Fix #5994: make etc/run-jupyterhub.sh work again - notebook must now be installed explicitly - serverextension call is no longer needed with the version of notebook we install - jupyterhub_debug was removed in favor of feature_config.debug but this needed to be cascaded in the jupyterhub conf jinja * fix list * importable package is with an underscore * install deps so users dont have to --------- Co-authored-by: Raven <ravenmarieorourke@gmail.com> * fix #6029 omega qcall work-around (#6030) * fix #5734 fixes for email login on react (#5973) * Fix #5819 radia lock objects (#5969) * fix #6013 work-around hellweg rf fields bug (#6014) * Fix #5948 always calculate n0 and n2 using fenics (#6015) * Fix #6004: change laser pulse units (#6016) * Fix #6032 - try small instead of subscript (#6035) * Fix #6044 - replaced segmentationCylRadius field in view (#6045) Co-authored-by: mkeilman <mkeilman@radiasoft.net> * fix #5588 omega improvements (#6054) * Fix #6055 default to tornado api_server in dev mode (#6072) * Fix #6055 default to tornado api_server in dev mode * Fix #6074 remove google_tag_manager --------- Co-authored-by: Raven <ravenmarieorourke@gmail.com> * Fix #6083: auth.login creates the uid (#6084) In 791364f the api_authEmailAuthorized code was changed from passing the user model we acquired based on searching by the email token to one acquired by searching for the uid into auth.login. Previous behavior: 791364f#diff-109de77eab3047455095be7e4c1f5f1d918083adaa02b87d5c862a8e513e8436L61 Behavior introduced in 791364f: 791364f#diff-109de77eab3047455095be7e4c1f5f1d918083adaa02b87d5c862a8e513e8436R89 But, the uid isn't present on the model. auth.login creates the user and populates the uid. In the case where we have multiple records in auth_email_user_t without a uid the query would return all of the records even though we are looking for just one. This reverts the behavior to what it was previously. * fix #6077 fix to omega for new opal release (#6090) * Fix #5936: beamline named amplifier for silas (#6043) * Fix #6037: replace experimental comparison with new example (#6080) * Fix #6046: "completed reports" instead of "animation" (#6051) * fix #6093 silas crystal UI improvements (#6094) * Fix #6017 improve cloudmc 3d toolbar (#6027) * fix #5829 implement parallel geometry extraction (#6048) * Fix #6049 - all object edges now black (#6050) * Fix #6047 - added axis ratio parameter (#6052) * fix 6095 increase server_test timeout (#6096) * fix #6058: raydata start and stop search times pre-populated (#6082) * Fix #6095 added TestClient.DEFAULT_TIMEOUT_SECS (#6098) * Fix #6101 increase timeouts in file_lock_test (#6102) --------- Co-authored-by: Michael Keilman <30352290+mkeilman@users.noreply.github.com> Co-authored-by: Gurhar Khalsa <49498231+gurhar1133@users.noreply.github.com> Co-authored-by: Paul Moeller <moeller@radiasoft.net> Co-authored-by: mkeilman <mkeilman@radiasoft.net> Co-authored-by: Rob Nagler <github@q33.us> Co-authored-by: Raven <ravenmarieorourke@gmail.com> Co-authored-by: Evan Carlin <evan@carlin.com>
This was referenced Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.