update branch #6109
Merged
update branch #6109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix #5596 Add file_lock concurrency protection - Fix #5740 ensure serial greater than incoming and on disk - Fix #5742 restricted critical sections and removed most - Fix #5743 migrate_guest_to_persistent_user locks new and guest uid - Fix #5744 simulation_dir uses lock_user - Fix #5745 validate version in save_simulation_json - Fix #5746 removed lock on auth.unchecked_get_user - Fix #5747 complete_registration passed display_name - Fix #5749 removed auth_db locking, verified all critical sections - Fix #5750 thread locking only in flask - Fix #5751 add auth.create_and_login_user for testing
…tion URL, Export as Zip, Python Source) in raydata settings submenu (#5891)
* Fix #5994: make etc/run-jupyterhub.sh work again - notebook must now be installed explicitly - serverextension call is no longer needed with the version of notebook we install - jupyterhub_debug was removed in favor of feature_config.debug but this needed to be cascaded in the jupyterhub conf jinja * fix list * importable package is with an underscore * install deps so users dont have to --------- Co-authored-by: Raven <ravenmarieorourke@gmail.com>
In 791364f the api_authEmailAuthorized code was changed from passing the user model we acquired based on searching by the email token to one acquired by searching for the uid into auth.login. Previous behavior: 791364f#diff-109de77eab3047455095be7e4c1f5f1d918083adaa02b87d5c862a8e513e8436L61 Behavior introduced in 791364f: 791364f#diff-109de77eab3047455095be7e4c1f5f1d918083adaa02b87d5c862a8e513e8436R89 But, the uid isn't present on the model. auth.login creates the user and populates the uid. In the case where we have multiple records in auth_email_user_t without a uid the query would return all of the records even though we are looking for just one. This reverts the behavior to what it was previously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.