Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Toast] Allow children in Viewport types for asChild composition #1300

Merged
merged 1 commit into from
Apr 4, 2022
Merged

[Toast] Allow children in Viewport types for asChild composition #1300

merged 1 commit into from
Apr 4, 2022

Conversation

benoitgrelard
Copy link
Collaborator

Fixes #1284

@benoitgrelard benoitgrelard deleted the toast-types branch April 4, 2022 11:18
@benoitgrelard benoitgrelard restored the toast-types branch April 4, 2022 11:18
@benoitgrelard benoitgrelard reopened this Apr 4, 2022
@andy-hook
Copy link
Collaborator

The same issue likely exists for NavigationMenu

@benoitgrelard
Copy link
Collaborator Author

The same issue likely exists for NavigationMenu

@andy-hook, feel free to raise a separate PR is so then 👍

@benoitgrelard benoitgrelard merged commit 2d84dd1 into main Apr 4, 2022
@benoitgrelard benoitgrelard deleted the toast-types branch April 4, 2022 11:49
luisorbaiceta pushed a commit to luisorbaiceta/primitives that referenced this pull request Jul 21, 2022
@benoitgrelard @luisorbaiceta
[Toast] Allow children in Viewport types for asChild composition (
5e6493a 
radix-ui#1300)
@lukemartin lukemartin mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-hook andy-hook andy-hook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Toast] Viewport TS error when adding children and asChild
2 participants
@benoitgrelard @andy-hook