Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Toast] Allow children in Viewport types for asChild composition #1300

Merged
merged 1 commit into from
Apr 4, 2022
Merged

[Toast] Allow children in Viewport types for asChild composition #1300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .yarn/versions/3abef429.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
releases:
"@radix-ui/react-toast": patch

declined:
- primitives
2 changes: 1 addition & 1 deletion packages/react/toast/src/Toast.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ const VIEWPORT_RESUME = 'toast.viewportResume';

type ToastViewportElement = React.ElementRef<typeof Primitive.ol>;
type PrimitiveOrderedListProps = Radix.ComponentPropsWithoutRef<typeof Primitive.ol>;
interface ToastViewportProps extends Omit<PrimitiveOrderedListProps, 'children'> {
interface ToastViewportProps extends PrimitiveOrderedListProps {
/**
* The keys to use as the keyboard shortcut that will move focus to the toast viewport.
* @defaultValue ['F8']
Expand Down