Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix usage of inert for React 19 #509

Closed
wants to merge 1 commit into from

Conversation

chrisirhc
Copy link

Description

facebook/react#24730 has landed to React 19.
When using radix-ui/themes with React 19, and using the Skeleton component, I get a warning that looks like:

Warning: Received an empty string for a boolean attribute `inert`. This will treat the attribute as if it were false. Either pass `false` to silence this warning, or pass `true` if you used an empty string in earlier versions of React to indicate this attribute is true.
    at span
    at eval (webpack-internal:///(ssr)/./node_modules/@radix-ui/themes/dist/esm/components/skeleton.js:11:179)

Testing steps

Ran my application with this fix and no longer saw the warning.

Relates issues / PRs

facebook/react#24730

Copy link

vercel bot commented May 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
themes-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2024 1:50pm

@vladmoroz
Copy link
Contributor

Thanks for the contribution – took a note of your implementation. We'll be looking at supporting React 19 holistically in #526

@vladmoroz vladmoroz closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants