React 19 support (RC) #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
June 3, 2024 12:36
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lucasmotta
approved these changes
Jun 11, 2024
| "eslint-plugin-react": "7.28.0", | ||
| "eslint-config-turbo": "^1.9.3" | ||
| "eslint-plugin-turbo": "2.0.3" |
There was a problem hiding this comment.
Is this package change intentional? If so we should also update the eslint-config-custom to use it as a plugin instead of a config.
There was a problem hiding this comment.
I had an issue when it requested I'd use the plugin, but rolling it back and just upgrading eslint-config-turbo it's gone now
Probably was a stale lockfile thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@types/reactwas having a hiccup with the current lockfile, removed the lockfile to resolve that, which triggered a bunch of other deps-related changes, liketurboupgrade. I resolved the latter but pinned all deps to specific versions to avoid this in the future)inertin React 19