[ABW-3644] Seed phrase entry/view updates #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danvleju-rdx
approved these changes
Aug 1, 2024
GhenadieVP
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-3644
Description
Hintto support a smaller icon size when showing an error, which is necessary forAppTextField.Hint.ViewStateto hold anAttributedStringrather than a renderedTextHint.ViewStaterather than the rendered view.Notes
There are still some improvements to be done regarding the Header used when viewing seed phrase (could be a regular navigation title), as well as defining whether we want to show the screenshot alert when entering seed phrase. These questions have been raised in Slack.
Before vs After
before.enter.mov
after.enter.mov
before.view.mov
after.view.mov