Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ABW-3655][ABW-3656] Entry seed phrase updates #1261

Merged
merged 6 commits into from
Aug 6, 2024
Merged

[ABW-3655][ABW-3656] Entry seed phrase updates #1261

merged 6 commits into from
Aug 6, 2024

Conversation

matiasbzurovski
Copy link
Contributor

@matiasbzurovski matiasbzurovski commented Aug 2, 2024 •
edited by jira bot
Loading

Jira ticket: ABW-3655
Jira ticket: ABW-3656

Depends on: #1255

Description

This PR:

  • Removes placeholder words from Entry Seed Phrase view
  • Allows moving to next seed phrase word when tapping on return key
  • Fixes UI issue where word would incorrectly align when showing an error.

Video

demo.mov

kugel3
kugel3 approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@kugel3 kugel3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we given up on the completion bar?

@matiasbzurovski matiasbzurovski merged commit d224674 into ABW-3644-seed-phrase Aug 6, 2024
6 checks passed
@matiasbzurovski matiasbzurovski deleted the ABW-3656-entry-seed-updates branch August 6, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyonAlexRDX CyonAlexRDX CyonAlexRDX left review comments

@kugel3 kugel3 kugel3 approved these changes

@GhenadieVP GhenadieVP GhenadieVP approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matiasbzurovski @CyonAlexRDX @GhenadieVP @kugel3